Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI Build Matrix to decrease testing time #4

Merged
merged 2 commits into from May 1, 2014

Conversation

t-mat
Copy link
Contributor

@t-mat t-mat commented Apr 30, 2014

@Cyan4973
Copy link
Member

Thanks Takayuki, it looks very good.

Is there a reason why you believe it's a good idea to have a Travis build status badge of the dev branch in the main readme.md (aka github status page) ?

Cyan4973 added a commit that referenced this pull request May 1, 2014
Add Travis CI Build Matrix to decrease testing time
@Cyan4973 Cyan4973 merged commit d7ebeb7 into lz4:dev May 1, 2014
@t-mat
Copy link
Contributor Author

t-mat commented May 1, 2014

Oops, I'm too late ⏰
I think build badge will indicate :

  • It has automated test.
  • 'Failed' status tells to users "you should not use this branch, for now".

And I've overlooked .travis.yml in master branch. So I would like to fix my commit (7290199) like this :

Branch Status
master Build Status
dev Build Status
|Branch      |Status   |
|------------|---------|
|master      | [![Build Status](https://travis-ci.org/Cyan4973/lz4.svg?branch=master)](https://travis-ci.org/Cyan4973/lz4) |
|dev         | [![Build Status](https://travis-ci.org/Cyan4973/lz4.svg?branch=dev)](https://travis-ci.org/Cyan4973/lz4) |

@Cyan4973
Copy link
Member

Cyan4973 commented May 2, 2014

Yeah, looks great

@Cyan4973
Copy link
Member

Cyan4973 commented May 3, 2014

Mmmh, does that work ?
I've updated the readme as suggested (dev branch)
to display a small table with master/dev branches status,
but I've got the feeling that both tags show the same status, and link to the same address.

@t-mat
Copy link
Contributor Author

t-mat commented May 4, 2014

It seems working. Here is my experimental branch and my build history.

  • My dev branch has never been built because I've never pushed dev branch to my repo.
  • My travis-ci branch has bad Makefile to force error.

but I've got the feeling that both tags show the same status, and link to the same address.

Yes. Link URL (second paren) is same.

You can see a badge snippet at Travis CI.
Click build | passing image button in upper right corner, then dialog will popup. Also you can change branch list box in the dialog.

@Cyan4973
Copy link
Member

OK, thanks, your example is very demonstrative,

indeed, all 3 cases do display differently, even though they do link to the same address.
Clear enough, thanks Takayuki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants