Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to compile on FreeBSD #28

Closed
cmumford opened this issue Sep 9, 2014 · 3 comments
Closed

Fails to compile on FreeBSD #28

cmumford opened this issue Sep 9, 2014 · 3 comments
Assignees
@cmumford

Comments

@cmumford
Copy link
Contributor

cmumford commented Sep 9, 2014

Original issue 22 created by dforsythe on 2011-07-23T08:14:20.000Z:

What steps will reproduce the problem?

  1. gmake

What is the expected output? What do you see instead?
Expect working bins and tests. Build fails because build_detect_platform doesn't recognize FreeBSD.

What version of the product are you using? On what operating system?
rev 39, FreeBSD 9.0-CURRENT

The attached patch fixes the build.
@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #1 originally posted by gabor@google.com on 2011-07-25T20:15:58.000Z:

Thanks dforsythe! I'll be working on patching in your changes.

Before I can patch them in, however, can you please fill out this online contributor agreement?
http://code.google.com/legal/individual-cla-v1.0.html
This will let us add your patch to the LevelDB codebase.
Let me know when you have done so.

Thanks again for your patch - looking forward to having LevelDB compiling on FreeBSD.

Gabor Cselle
Product Manager, Google

@cmumford cmumford self-assigned this Sep 9, 2014
@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #2 originally posted by dforsythe on 2011-07-25T20:35:26.000Z:

I've completed the agreement. Thanks!

@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #3 originally posted by gabor@google.com on 2011-07-27T04:50:29.000Z:

This is now fixed in Revision 40. Can you verify.

@cmumford cmumford closed this as completed Sep 9, 2014
@magicSwordsMan magicSwordsMan mentioned this issue Jul 19, 2019
Open
@orrorcol orrorcol mentioned this issue Dec 15, 2019
Closed
maochongxin pushed a commit to maochongxin/leveldb that referenced this issue Jul 21, 2022
@dominichamon
Merge pull request google#28 from pleroy/PausePure
35da167 
Take the CPU time into account in PauseTiming/ResumeTiming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmumford cmumford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmumford