My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 20: Templates created using FromFile with unicode strings are broken
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  gtempacc...@yahoo.com
Closed:  Sep 2009


 
Project Member Reported by gtempacc...@yahoo.com, May 5, 2009
Files are byte streams by definition, so textual data needs an encoding. 
FromString should probably either accept unicode() or str()

May 14, 2009
#1 Robert.David.Williams
Yes, encoding should be explicitly handled, or explicitly dumped onto the user (caller).

Since properly handling character encoding is very troublesome, especially when you
mix in BOMs and HTML/XML, it probably should be treated as a separate feature set
(separate project even?) or greatly simplified.

Maybe FromFile() should simply be dropped, and let the user/caller handle the mapping
from a file to FromString().
May 14, 2009
Project Member #2 andyc...@gmail.com
It's worth considering dropping FromFile, but I'll see if I can just make it do
something reasonable.  This is Python-specific, and Python can handle unicode alright.

We would never sniff content, the encoding function param would just be authoritative.

Labels: Release-Blocking
May 14, 2009
Project Member #3 andyc...@gmail.com
(No comment was entered for this change.)
Labels: -Release-Blocking ReleaseBlocking
Sep 24, 2009
Project Member #4 andyc...@gmail.com
Fixed by r281
Summary: Templates created using FromFile with unicode strings are broken
Status: Fixed

Powered by Google Project Hosting