Issue 6: Show Toolbar Separators only if required
Status:  Fixed
Owner: ----
Closed:  Apr 2007
Reported by rain...@gmail.com, Feb 22, 2007
The following patch adds the separators between toolbar actions only if
the prior item is shown.

Also added a createToolBar(boolean) method to ToolBarFactory to allow
disabling of separators completely. 
separator.patch
2.1 KB   Download
Feb 22, 2007
#1 extremec...@gmail.com
Good idea! I changed it around slightly though. I did not want the interface to be
changed because of an implementation enhancement just to keep things more generic.
So, instead I added an enableSeparators() boolean to the implementation of the
ToolbarFactory. I did not get a chance to test this very good yet, but I did make the
changes and checked them into subversion. I really need to get some unit tests around
this anyway so I will leave this issue open until I get that in place.

Here is an example that turns off the separators:

ToolbarFactoryImpl toolbarFactory = new ToolbarFactoryImpl(table, webContext,
coreContext, CSV);
toolbarFactory.enableSeparators(false);

Status: Started
Feb 22, 2007
#2 rain...@gmail.com
Yep, this sounds pretty good.
Thanks for adding this to the core.

-Rainer
Apr 1, 2007
#3 extremec...@gmail.com
(No comment was entered for this change.)
Status: Fixed