| Issue 207: | RFE: remove drop-down autosubmit and add keyboard navigation support to filters . | |
| 1 person starred this issue and may be notified of changes. | Back to list |
This patch does several things: Fix minor bugs: - drop-down filter div creation missing end '</div>'. - drop-down filter didn't have current value selected. Fix ui problem: - drop-down filter auto submits on selection: this is not - consistent with the other filters (without auto submit) - and confuses users. Adds: - keyboard navigation between filters: -- tab moves to next filter -- shift tab moves to previous filter -- escape key closes the drop-down filter Tested in ff 2, 3.5.1, ie 6, 7, 8 and opera 10. This patch started with an user requirement to disable auto-submit in the drop-down filters: Either all filters should auto-submit or no filter should auto-submit.
Jul 23, 2009
Project Member
#1
jeff.johnston.mn@gmail.com
Jul 28, 2009
I still need to look closer at this as it would be a big global change. Having the droplists auto-submit has not been an issue before. But, regardless, that does not mean that we cannot make this more plugable. At minimum the JavaScript calls should be in the preferences so that you can invoke a different method without having a custom filter editor.
Jul 28, 2009
Have you tried the patch? After trying this, you will be dragged back screaming to to the no focus filters as they are today :P Just (somewhat) kidding, but the patch really greatly improves filter usability. What I'm missing is the point of your message though, specially about the "invoke a different method without having a custom filter editor". The patch really does not change things much. They just add some functionality to the existing createDynFilter and createDroplistDynFilter methods: - create an "updateFilter" method which updates the filter and disposes the dynamic filter instead of this code being replicated in several event handlers. - change the event handlers to catch the tab/shift-tab/escape keys. - add some event code and some code around input.focus() to workaround browser focus and keyboard quirks. - add the transferDynFocus method which finds the next/previous filter and does a "click" on it. I'm in no hurry to have this committed, as I agree that a bit (a lot would be better) more testing would be useful. Just my .02€ PS: just reread your point of more pluggable: Do you mean that this patch should create two new createDyn*** methods for creating the dynamic filters and have a properties setting to choose which filter to use (haven't looked at the code to see if this is possible)?
Jul 29, 2009
Thank you for the detailed reply... What I meant was that, ideally, a developer would not have to modify the core JavaScript or create a FilterEditor to call a custom JavaScript method. For instance, lets say your droplist remains custom. It would be nice if the API could just call your method. We could do that if it was wired up through the preferences. I do really like the tabbing between filters! Nothing not to like about that...although it did not work on my machine for some reason. I run Firefox 3 on Ubuntu Linux. I am not sure the droplist not auto-committing is a feature though. I wanted to poll more people and see what they thought. In the short run it would be nice to separate the tabbing improvement from the droplist. I would except the filter tabbing improvement right away if it worked well. Would you be willing to do that as a first step?
Status:
Accepted
Oct 20, 2009
(No comment was entered for this change.)
Status:
WontFix
|