My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 186: Make jquery.jmesa.js "lint free"
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Apr 2010


 
Reported by bgo...@e1b.org, Apr 2, 2009
I think that it is not a bad idea to modify JMesa's javascript to make it
be able to pass JSLint's validator using "The Good Parts" button.

Mostly this involves several changes:

1) Scoping the inadvertently global variable 'classes' so that it local instead

2) Changing '==' and '!=' to '===' and '!=='

3) Using [] and {} instead of 'new Array()' and 'new Object()'

along with a few other small tweaks and whitespace rules.  Obviously, the
javascript is working fine as it is, but JSLint is good at catching common
JavaScript error that occur because of its dynamic nature (like #1 above)
and its forgiving parser.

I don't want to hold up the next release for this, but I have already made
the changes and I am testing them in my own project right now.  The only
thing that I will need help testing the worksheet because I don't use that yet.

What do you think?
Apr 2, 2009
Project Member #1 jeff.johnston.mn@gmail.com
If you are confident of the changes I will test out the worksheet part. I think if
you already have the work done then we should just make the change...I am all for
improving the framework! It will delay the release a little, but I think the
developers that requested the changes they needed are running off of custom builds
anyway. Maybe we just say that this change is the last for the next release.

Also, could you include how to test with JSLint's validator?
Status: Accepted
Apr 2, 2009
#2 bgo...@e1b.org
actually, I'm not so confident yet, I just wanted to see what you thought of the
idea.  To run JSLint I usually just go to jslint.com, paste in the code, hit "The
Good Parts" button and then hit the "JSLint" button.  I'm sure there's a way to
integrate it into ant using Rhino (which I think we have in the repository already,
right?)
Apr 2, 2009
Project Member #3 jeff.johnston.mn@gmail.com
How about if we wait until after the next release then...I'll do a release this
weekend. We get JMesa lint free after that!

Yep, Rhino is under the name js-1.7R1.jar.

Apr 13, 2010
Project Member #4 jeff.johnston.mn@gmail.com
(No comment was entered for this change.)
Status: WontFix

Powered by Google Project Hosting