My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 185: DroplistFilterEditor doesn't show all options with auto filtering and sorting disabled
1 person starred this issue and may be notified of changes. Back to list
Status:  Done
Owner:  ----
Closed:  Apr 2009


 
Reported by bgo...@e1b.org, Mar 17, 2009
Typical usage for this filter editor is to use it with a small number of
items, which it then introspects for all of the distinct values available.
 Problems occur, however, when you set the total rows on the limit yourself
and only pass in a subset of all of the items.  If not all of the possible
values are included in the subset, they are not included in the filter
editor's droplist.

If this is an enumeration (or the results of lookup table or something), I
know the possible values, so it would be nice if I could set them myself.

This is actually really easy to accomplish by overriding getOptions(), but
I think that built-in support for a method like setOptions(String[][])
would be prudent (like DefaultTableModel for JTable).

If you think this is a good idea, I can submit the code and try to sneak it
in before the next release.
Mar 17, 2009
Project Member #1 jeff.johnston.mn@gmail.com
You and one other developer are totally driving this next release so feel free to
submit that patch! The only thing I will do is delay the release so that the code
sits on the trunk for a few days. That gives other developers a chance to try out the
code and also more time to ensure that things work as expected.
Status: Accepted
Mar 30, 2009
Project Member #2 jeff.johnston.mn@gmail.com
Just checking on your progress...I'm thinking that we should just do another release
this week and then put this change out after that. What do you think?
Mar 30, 2009
#3 bgo...@e1b.org
Actually just finished this patch a few minutes ago and I was testing it out.  I
think that the changes are fairly straightforward, but please let me know if you have
any questions.
patch.txt
6.8 KB   View   Download
Mar 30, 2009
Project Member #4 jeff.johnston.mn@gmail.com
Great! I'll take a look at this in the next couple days.
Apr 1, 2009
Project Member #5 jeff.johnston.mn@gmail.com
I have the patch applied and on the trunk now. Nice work! I did some super small
tweaks. One was renaming options in the methods to opts so that the value was not
overriding the global variable. I try to avoid that nowadays although I'm sure you'll
see code that is still doing it...I just try not to. I also combined one of the
bulletproof checks.

In addition I did one small tweak to the jquery.jmes.js file in that I took out the
encoding for the setting of the hidden input filter fields. The browser will do that
automatically and the encoding was messing up some values.

Let me know if any of my small tweaks broke anything. Other than that I think we are
ready for another release!

Apr 5, 2009
Project Member #6 jeff.johnston.mn@gmail.com
(No comment was entered for this change.)
Status: Done

Powered by Google Project Hosting