My favorites | Sign in
Project Home Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 80: API entry_get_actor_overview doesn't work
3 people starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Owner:  tony.t.t...@gmail.com
Closed:  Jun 2009
Cc:  andyster, adewale


 
Reported by amr.most...@gmail.com, Apr 2, 2009
The API call entry_get_actor_overview incorrectly passes "offset" argument
to entry_get_inbox which since_time.

Patch attached.

What version of the product are you using? On what operating system?
Revision 40

Please provide any additional information below.
This currently affects jaiku.com service as well. If someone knows, please
advice on whether I should contact jaiku.com or not.
jaiku_api_entry_offset.patch
495 bytes   View   Download
Apr 3, 2009
Project Member #1 tony.t.t...@gmail.com
Can you please send the patch to http://rietku.appspot.com/ ?

Thanks!
Apr 22, 2009
Project Member #3 andyster
(No comment was entered for this change.)
Status: WorksForMe
May 1, 2009
Project Member #4 tony.t.t...@gmail.com
I think the issue here is the word "offset". When I see the word "offset", I
automatically associate it with the offset keyword in sql. Without reading the doc
closely, I'd assume the offset parameter indicates the number of entries to skip
before returning the result.

How about renaming the parameter to something like "before_time"? While we're here,
maybe deprecate entry_get_actor_overview and replace it with
entry_get_actor_overview_before?
Status: Accepted
Owner: tony.t.tseng
Cc: andyster adewale
May 18, 2009
Project Member #5 andyster
I'm a bit ambivalent towards changing the name of the argument. On one hand it is
more clear, on the other I don't think the existing usage is particularly confusing
Jun 5, 2009
Project Member #6 tony.t.t...@gmail.com
I'll mention this when updating the api doc.
Status: Duplicate
Mergedinto: 116

Powered by Google Project Hosting