| Issue 80: | API entry_get_actor_overview doesn't work | |
| 3 people starred this issue and may be notified of changes. | Back to list |
The API call entry_get_actor_overview incorrectly passes "offset" argument to entry_get_inbox which since_time. Patch attached. What version of the product are you using? On what operating system? Revision 40 Please provide any additional information below. This currently affects jaiku.com service as well. If someone knows, please advice on whether I should contact jaiku.com or not.
Apr 3, 2009
Project Member
#1
tony.t.t...@gmail.com
Apr 4, 2009
Done! http://rietku.appspot.com/3009
Apr 22, 2009
(No comment was entered for this change.)
Status:
WorksForMe
May 1, 2009
I think the issue here is the word "offset". When I see the word "offset", I automatically associate it with the offset keyword in sql. Without reading the doc closely, I'd assume the offset parameter indicates the number of entries to skip before returning the result. How about renaming the parameter to something like "before_time"? While we're here, maybe deprecate entry_get_actor_overview and replace it with entry_get_actor_overview_before?
Status:
Accepted
Owner: tony.t.tseng Cc: andyster adewale
May 18, 2009
I'm a bit ambivalent towards changing the name of the argument. On one hand it is more clear, on the other I don't think the existing usage is particularly confusing
Jun 5, 2009
I'll mention this when updating the api doc.
Status:
Duplicate
Mergedinto: 116 |