Issue 89: mencoder called before comskip has completed
Status:  Fixed
Owner:
Closed:  Mar 2009
Reported by edmcqu...@gmail.com, Feb 19, 2009
What Version of iTiVo?
1.7.2
What Version of MacOS X?
10.5.6
What download format did you select?
Decrypt/Copy + Remove Commercials
What steps will reproduce the problem?
1. Select Decrypt/Copy
2. Enable Commercial Skip
3. Download a 30 minute show

Please provide any additional information below.
I checked Activity Monitor, and the comskip process continued to run long
after mencoder was called.
I think that this may be causing many of the problems people are having
where a very short and invalid file is created.  Perhaps some additional
checking can be added to the applescript to ensure that comskip has
actually completed.

iTiVo.log
39.4 KB   View   Download
Feb 19, 2009
Project Member #1 yoav.yer...@gmail.com
oops.. that's a bug..  iTiVo decided to time out waiting on mencoder and just
proceed.   The curious question is why comskip was being incredibly slow (itivo gives
it two minutes to make progress finding the commercial, and if it doesn't, it gives
up and goes and works with whatever it has).

  I guess for the next release I'll give comskip 5 minutes to make progress.. but it
*really* shouldn't be taking that long...

  (The point of the timeout is that sometimes comskip just hangs and makes no
progress.. so generally in that situation we go ahead and encode with whatever cuts
comskip found before it got stuck -- It looks like here comskip was working, just
very slowly)
Status: Accepted
Feb 19, 2009
#2 edmcqu...@gmail.com
Maybe it's related to the size of the show, or the bitrate for that matter.  I have
only run into this for HD shows.
Feb 19, 2009
Project Member #3 yoav.yer...@gmail.com
I'm increasing the timeout to 5 minutes on the next release (so hopefully it will not
timeout this time).  I'm also going to change the behavior so if it times out on a
commercial cut, it will ignore ALL cuts and use the original instead (just in case
the file that it DOES have has bad cuts in it).

  I'm holding off on releasing this until I can get some more code changes in first
for other stuff though.
Feb 19, 2009
#4 edmcqu...@gmail.com
Thanks Yoav.

I like your idea to use the original if the commercial cut fails.  
Feb 20, 2009
Project Member #5 yoav.yer...@gmail.com
Ok, download the latest beta and see if it fixes the problem?

Mar 22, 2009
#6 edmcqu...@gmail.com
Yoav, This is working correctly for me now.  Thanks for the update!

I tried to closed the defect, but don't see a way to do that.
Mar 22, 2009
Project Member #7 yoav.yer...@gmail.com
Ok thank you for catching this bug.  Marking the bug 'fixed'.

Status: Fixed