Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google escape library to Guava #799

Closed
gissuebot opened this issue Oct 31, 2014 · 21 comments
Closed

Add google escape library to Guava #799

gissuebot opened this issue Oct 31, 2014 · 21 comments

Comments

@gissuebot
Copy link

Original issue created by g.j.bowyer on 2011-11-21 at 07:36 PM


Hi guys

would it be possible to add the code that google has written for escapers into guava

specifically the code that is hidden in gdata here http://code.google.com/p/gdata-java-client/source/browse/#svn%2Ftrunk%2Fjava%2Fsrc%2Fcom%2Fgoogle%2Fgdata%2Futil%2Fcommon%2Fbase

These are about the best format escapers I have come across in a long time and have allowed us to replace a huge number of in house hack jobs.

@gissuebot
Copy link
Author

Original comment posted by g.j.bowyer on 2011-11-21 at 08:37 PM


Sweet !!

Thanks that is awesome

@gissuebot
Copy link
Author

Original comment posted by kevinb@google.com on 2011-11-21 at 11:04 PM


Well, this made my day. :)

@gissuebot
Copy link
Author

Original comment posted by cgdecker on 2011-11-22 at 03:17 AM


(No comment entered for this change.)


Labels: Milestone-Release11

@gissuebot
Copy link
Author

Original comment posted by wasserman.louis on 2011-12-17 at 05:17 PM


I observe that this has been "removed for the moment." ??

@gissuebot
Copy link
Author

Original comment posted by xaerxess on 2012-01-03 at 04:00 PM


Escape library didn't make its way to release 11, as far as I can see...

@gissuebot
Copy link
Author

Original comment posted by cgdecker on 2012-01-03 at 04:16 PM


Well, I'm not sure what the plan is for this now. I'll just reopen this and let someone else update it if there's more information.


Status: Triaged
Labels: -Milestone-Release11

@gissuebot
Copy link
Author

Original comment posted by wasserman.louis on 2012-01-03 at 06:10 PM


I think it's fair to mark this as "started," since it was briefly in Git?


Status: Started

@gissuebot
Copy link
Author

Original comment posted by garretdwilson on 2012-04-27 at 04:52 PM


Darn, I was looking for a common escaping library, and I got all happy when I read this. I got less happy when I tried to access it in guava 11.02 in my IDE... :(

@gissuebot
Copy link
Author

Original comment posted by wasserman.louis on 2012-04-27 at 05:11 PM


From what I've been told, the API needed significant cleanup before it could meet Guava's standards. I don't know if we have a time estimate, but it'll make it out eventually.


Labels: Type-Enhancement

@gissuebot
Copy link
Author

Original comment posted by kevinb@google.com on 2012-05-30 at 07:43 PM


(No comment entered for this change.)


Labels: -Type-Enhancement, Type-Addition

@gissuebot
Copy link
Author

Original comment posted by kevinb@google.com on 2012-06-22 at 06:57 PM


(No comment entered for this change.)


Labels: Package-General

@gissuebot
Copy link
Author

Original comment posted by ori.schwartz on 2012-08-29 at 08:53 PM


Closure templates has a very thorough implementation of this in package com.google.template.soy.internal.base .

The API is clean, it has been used in production for a long time, it performs well, and it's already open source:

http://code.google.com/p/closure-templates/source/browse/#svn%2Ftrunk%2Fjava%2Fsrc%2Fcom%2Fgoogle%2Ftemplate%2Fsoy%2Finternal%2Fbase

@gissuebot
Copy link
Author

Original comment posted by cpovirk@google.com on 2012-08-29 at 08:58 PM


Indeed, that's our implementation, temporarily clone into Closure's codebase until we get our act together :)

@gissuebot
Copy link
Author

Original comment posted by wasserman.louis on 2012-08-29 at 09:22 PM


If the guys working on this think the API can be improved still further, I'm inclined to wait.

@gissuebot
Copy link
Author

Original comment posted by shaki6a on 2013-03-01 at 03:20 AM


Is there any update on this issue?

@gissuebot
Copy link
Author

Original comment posted by kak@google.com on 2013-03-01 at 03:36 AM


It's on our list of goals for Guava 15!


Labels: Milestone-Release15

@gissuebot
Copy link
Author

Original comment posted by ipremraj11 on 2013-04-22 at 06:11 PM


Awesome! Thanks.

@raphaeljolivet
Copy link

@cpovirk
Copy link
Member

cpovirk commented Feb 18, 2016

For SourceCodeEscapers, see #1620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants