-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trie interface(s) and implementation(s) #10
Comments
Original comment posted by kevinb9n on 2007-10-01 at 07:51 PM thanks! It would be really, really (really) helpful if we could collect, here, a good variety |
Original comment posted by sberlin on 2007-10-01 at 08:10 PM We use it internally for a few cases. 2) Storing a Kademlia DHT's internal structure. This is probably a very specific Other use cases: I'm sure there's a ton of other cases, but those are the ones we use (and have plans |
Original comment posted by kevinb9n on 2007-10-16 at 03:37 PM Great stuff, folks. Thanks so much. With the sheer mountain of work involved in getting our existing stuff polished, I'm Status: |
Original comment posted by kevinb9n on 2007-10-23 at 04:29 AM Disclaimer: I don't know much about Tries. I can imagine that many use cases for a Trie break into at least two categories
public interface Trie<N, V> { A separate issue: should we consider providing an alternate interface that is |
Original comment posted by sberlin on 2007-10-23 at 05:49 AM From my experience, #1 is exactly right. A Trie easily doubles as a super-efficient You hit the nail on #2 with the CharSequence version. Trie's I've encountered public interface Trie<K, V> { The difference is the Trie is directly acting off a K value, which would be the The Trie interface in the submission includes a few additional convenience methods |
Original comment posted by sberlin on 2007-10-23 at 05:50 AM (Really, that getPrefixedBy could just return a List<V> - having it return a vw of |
Original comment posted by kevinb9n on 2007-11-03 at 05:32 PM (No comment entered for this change.) Labels: |
Original comment posted by kevinb9n on 2008-06-02 at 05:48 PM (No comment entered for this change.) Labels: - |
Original comment posted by tim.frey.online on 2009-03-22 at 10:31 AM Hello, currently I'm wirting something for my studies and did a bit of research about Tries. In my opinion it maybe would be a great advantage to use this Trie. Hope I could help, |
Original comment posted by ray.a.conner on 2009-08-03 at 05:53 PM To completely generalize it, a Trie is kind of a particular way of representing a There may be some benefit to completely abstracting it in this way, although |
Original comment posted by ray.a.conner on 2009-08-03 at 06:05 PM As a use case, I've used it for finding phrases within a large text document. I have
Generalizing, this is finding all possible subsequences of List<E> (the text) that The big benefit is that the text, which can be very large, only needs to be traversed |
Original comment posted by creswick on 2009-08-03 at 06:31 PM I have the same use case as Ray.a.conner, and I'd also use it for scalable tab|auto- |
Original comment posted by sberlin on 2009-08-03 at 06:34 PM Are you folks using the attached PatriciaTrie implementation, or a separate one? |
Original comment posted by jared.l.levy on 2009-08-03 at 06:44 PM The Google code base includes multiple Java trie implementations. If we chose to add Labels: - |
Original comment posted by ray.a.conner on 2009-08-03 at 08:13 PM I rolled my own implementation, some years ago. I wasn't storing simple strings, and |
Original comment posted by kevinb9n on 2009-09-17 at 06:02 PM (No comment entered for this change.) Labels: |
Original comment posted by master.java.xiao on 2009-11-24 at 08:06 AM (No comment entered for this change.) |
Original comment posted by kevinb@google.com on 2010-07-30 at 03:54 AM (No comment entered for this change.) Owner: kev...@google.com |
Original comment posted by kevinb@google.com on 2010-07-30 at 03:56 AM (No comment entered for this change.) Labels: - |
Original comment posted by kevinb@google.com on 2011-01-27 at 01:59 PM (No comment entered for this change.) Owner: --- |
Original comment posted by kevinb@google.com on 2011-02-03 at 06:24 AM Work is beginning... expect in maybe release 10 or 11. Status: |
Original comment posted by rkapsi on 2011-02-24 at 10:35 PM Awesome! I don't know if it's of any use for you but our Trie has been under ASL 2.0 for a few years now and has undergone a few refacorings. <http://code.google.com/p/patricia-trie> The Trie interfaces are maybe useful even if you're not going to use PATRICIA. Cheers, |
Original comment posted by jim.andreou on 2011-02-25 at 02:35 AM Yep, will certainly take this into consideration, thanks for the links. I find the last method (#prefixMap(prefix)) especially nifty, exposing the recursive structure of a trie (though I would expect to see the self type being returned, instead of SortedMap, that's lossy). That said, I have to admit that personally I'm a bit predisposed against patricia. My reasoning is that for the same kind of performance, we could go with a ternary trie, which is more flexible (e.g. no key analyzer, not necessarily unbalanced trees). But I don't trust what "that kind of performance" means for big tries. I'm still going through the literature hunting for other options (e.g. http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.18.3499, http://www.naskitis.com/) |
Original comment posted by sberlin on 2011-02-25 at 02:55 PM It probably could return the Trie itself, but would require a bit more work to make sure the additional trie operations stayed with the sub-trie range. Roger & I ate, slept & breathed patricia for a couple weeks while putting this together years ago.. so don't hesitate to ask if you have any questions on it. |
Original comment posted by wasserman.louis on 2011-03-07 at 05:41 PM I'd be interested in working on this -- heh, I've been living and breathing http://hackage.haskell.org/package/TrieMap for some time now. |
Original comment posted by fry@google.com on 2011-03-23 at 01:48 AM (No comment entered for this change.) Labels: - |
Original comment posted by kevinb@google.com on 2011-07-13 at 06:19 PM (No comment entered for this change.) Status: |
Original comment posted by fry@google.com on 2011-12-10 at 03:11 PM (No comment entered for this change.) Labels: |
Original comment posted by ian.g.simpson on 2012-03-10 at 04:48 AM Any update on this? I just checked out 11.0.2 and I still don't see a Trie implementation in it. |
Original comment posted by kevinb@google.com on 2012-03-11 at 11:08 PM There's been some progress, but unfortunately it's not high-priority. :-( Unlikely for 13.0, maybe 14.0. |
Original comment posted by Sam.Halliday on 2012-08-01 at 07:30 PM +1 for Trie, I find myself wanting a solid Java implementation on occasion, and usually fall back to a TreeMap<String> hack which gets the job done (albeit with a much larger memory footprint). |
Original comment posted by onlynone on 2012-08-22 at 02:28 PM I'd be very interested in a Trie implementation in guava. I use hadoop and need to filter the incoming data by a large set of strings, on the order of 2 million strings. Right now I have a file containing these strings, one per line, that each mapper reads into a hashset to do the filtering. The speed performance is fine, it just takes a ton of memory. I've used the exact same approach with the exact same set of strings in c++ and it never took close to the amount of memory that java is using. The strings I'm filtering by have a good deal of common leading characters, I think our memory savings would be significant with a trie. I'd like to see a TrieMap and a TrieSet. |
Original comment posted by phraktle on 2012-11-15 at 11:53 PM An interesting project for concurrent tries: http://code.google.com/p/concurrent-trees/ |
Original comment posted by Ja...@wetheinter.net on 2013-01-24 at 01:32 PM I am presently finding Trie structures very useful in my code generation / dependency injection library. Scanning classpaths is expensive, and java packages often share long, repetitive package names; couple that with the fact my codegen library descends not just through the package structure, but the class, method, field and annotation structure as well (into a single uber-trie of your module), and a fast, concurrent trie is absolutely vital. Compared to the org.reflections classpath scanner (which uses MultiMap and single threaded scanning), my Trie-backed implementation can, if scanning multiple jars with multiple threads, run over seven times faster, and deliver deep iterators, instead of multiple MultiMaps delivering set views. +1 For Trie |
Original comment posted by Ja...@wetheinter.net on 2013-01-24 at 02:22 PM Sorry for the double post, but one more place I use Trie's for great effect: My StringTrie which uses char[] or CharSequence as keys, internally uses a CharPool that extends the base Trie structure, and translates a char[], start index and end index into singleton char[] instances (which pass == tests). This changed my memory footprint from double that of TreeMap to less than half (on larger datasets). My implementation does not store a node per character; rather, it will store a char[] matching a unique sequence of chars, and using a trie-backed CharPool, it will only create as many arrays as there are unique sequences in your data (and using a shared CharPool shared across instances ensures I never allocate a byte more memory than I need). In my benchmarks, I found that memory usage on highly-variant, dense data structures (like long sequences of toStringd() random numbers) was quite high (a new char[] per node), but with a CharPool to the rescue, memory usage was based on number of unique sequences + number of unique sequence combinations, instead of unique sequence combinations * number of sequences per combination. |
Original comment posted by knut.wannheden on 2013-01-24 at 02:40 PM Hi James, Any chance that you'll share your implementation? I also have a use case where I'm currently using a TreeMap (which allows for a poor man's prefix matching) and I would like to experiment with a Trie to save some memory. |
Original comment posted by Ja...@wetheinter.net on 2013-01-24 at 04:59 PM I'll package it up, put it on github in the near future, and reply back here with a link. Star the issue, and you'll get emailed. The concurrency support is tied directly into my own internal library (which does let you inject your own implementations for handling threads or ignoring multithreading), but the whole library itself is Not Safe For Work (tm). If I can't deploy a new version soon, I can put a cut out standalone of the trie and the charpool in a gist instead; just be warned that for small maps, you won't be saving space. Large maps, especially ones with common prefixes (or subsequences, using a shared CharPool) WILL save you on memory. For my purposes, I save lots, because I am working with long, repetitive strings (especially when descending into inner classes, methods, fields, vars, etc). If you just maintain a big map of mostly-unique strings, trie is probably not for you. |
Original comment posted by oliver.schrenk on 2013-03-15 at 12:04 PM Hi James, Did you have time to put your trie implementation up on github? I'm interested because I have a large pool of keys sharing very long prefixes and I'm interested in your approach. |
Original comment posted by ashwin.jayaprakash on 2013-03-15 at 05:01 PM Jetty util pkg has some Trie structures if it helps - http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-util/src/main/java/org/eclipse/jetty/util/ArrayTernaryTrie.java |
There was a request for use cases. I started to use the Trie in apache commons4 collections to use in lookups of longest matching prefix. Its not uncommon with rules based on phone number prefixes. Next is to do the same but for IP networks, almost like a routing table. Apache commons4 4.0 doesnt allow me to create a patricia tree on other types though. But I guess limewire is almost doing this, but refactoring has made the codebases diverge. The lookup tables will have around ~100k entries, and there about 100k lookups per second. |
We're not working on this anytime soon...and it will require a lot more investigation and studying. |
@kluever how about in 2017? :) |
Maybe 2019 is the ticket? :P |
2020? |
2021? Still no movement? |
2022? #weNeedTrie 😄 |
Given that this issue was opened in 2014, what would it take for this issue to be resolved + closed? |
2023? |
I'm emotionally attached to the idea that Guava could one day have this, but I guess it's time to face facts: we just aren't in an active feature mode anymore (even, for something of this scale, if it's externally-driven). So, I'll probably close this issue in 2033. Just kidding. |
Original issue created by sberlin on 2007-09-24 at 06:12 PM
This is a contribution of LimeWire's PatriciaTrie, as discussed at:
http://groups.google.com/group/google-
guice/browse_frm/thread/ffb2a3b3b9e39e79?tvc=1 .
The files can be licensed as necessary (we own the copyright and can
change/transfer the license). I'm not sure what license, if any, these
would need to be for inclusion.
The text was updated successfully, but these errors were encountered: