New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix GTEST_DEFINE_STATIC_MUTEX_ missing-field-initializers gcc warning #433
Comments
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Option (2) is perfectly standards-compliant regardless of the underlying type of pthread_mutex_t. Could we get this applied for those of us who like to compile with Complete patch looks like this. It is pretty small, but would you prefer a pull request?
|
Created pull request #633 |
* Setting up builtin subrepo mabob * Correct BuildLabel::String a bit. Unbelievably there's been a bug in there for like three bloody years. Fortunately nobody noticed... * Turns out that wasn't what I wanted. This is more better. * Update a bunch of libraries. Am getting 504s off Github. Not sure what has triggered that (I don't *think* it's related to my connection) but seems worth updating. * oops * Look for BUILD files in correct places * Just set State always so we don't have to do nil checks * Fix up some config stuff * Strip old stuff from build defs * Temp, for testing; use local repo * Add new_local_repository rule * think this makes things a bit better * Report better BUILD file locations * jarcat reference needs to be absolute * Adding a gtest example * add a custom build file for it * Revert "Temp, for testing; use local repo" This reverts commit 4d86304. * working on this test_x86 issue * Cleaning up some overly verbose logging * clean some things up * more subrepo chaos * move pleasings out of custom package (it's in the wrong place basically) * cleanup * fix for google/googletest#433 * Reverting the UnitTest++ changes for now
* Setting up builtin subrepo mabob * Correct BuildLabel::String a bit. Unbelievably there's been a bug in there for like three bloody years. Fortunately nobody noticed... * Turns out that wasn't what I wanted. This is more better. * Update a bunch of libraries. Am getting 504s off Github. Not sure what has triggered that (I don't *think* it's related to my connection) but seems worth updating. * oops * Look for BUILD files in correct places * Just set State always so we don't have to do nil checks * Fix up some config stuff * Strip old stuff from build defs * Temp, for testing; use local repo * Add new_local_repository rule * think this makes things a bit better * Report better BUILD file locations * jarcat reference needs to be absolute * Adding a gtest example * add a custom build file for it * Revert "Temp, for testing; use local repo" This reverts commit 4d86304. * working on this test_x86 issue * Cleaning up some overly verbose logging * clean some things up * more subrepo chaos * move pleasings out of custom package (it's in the wrong place basically) * cleanup * fix for google/googletest#433 * tweak coverage settings * update comment * Don't attach C++ dependency to C tests For now there is no config property, they'll have to be done manually. We could easily introduce later though.
Original issue reported on code.google.com by
gmark...@gmail.com
on 13 May 2013 at 12:43The text was updated successfully, but these errors were encountered: