IssueTracker

This also brings back dialog content size animations issues :( But on all devices this time.

See attached video

Repro:

Dialog(
                    onDismissRequest = {
                        if (dialogState.canDismiss.value) {
                            dialogNavigator.hide()
                        }
                    },
                    properties = properties,
                    content = {
                        Surface(
                            modifier = modifier
                                .safeContentPadding()
                                .fillMaxWidth(0.8f)
                                .animateContentSize(),
                            shape = shape,
                            color = backgroundColor,
                            contentColor = contentColor,
                        ) {
                            .....A composable that change it's size
                        }
                    },
                )

Can you give a fuller example for the animateContentSize() problem?

It does that for all the cases where the content change.

properties = DialogProperties(usePlatformDefaultWidth = false)

var show by remember { mutableStateOf(false) }

LaunchedEffect(Unit)  {
 delay(1000)
 show = true
}

Column {
  Text("X")
if (show) {
   Text"Y) 
}

}

Edit: This was a well known long time issue when not using usePlatformDefaultWidth = false so we were forced to workaround with that. Now even with it it trigger that. (Depending on the phone, it's either super slow, or laggy and jumping).

I am seeing a problem with decorFitsSystemWindows = false where it continues to invalidate the layout even after the animation completes. I don't think that's the problem you're worried about, though.

If I understand correctly, the problem you're seeing is something about it being laggy? And it didn't happen in the previous version, right?

That problem is likely due to the Window resizing on every frame, which is more expensive than the window content resizing on every frame. In a previous iteration, the window size was full screen and the content resized itself. You can resolve this yourself by doing this:

                Surface(
                    modifier = Modifier.safeContentPadding()
                        .fillMaxSize()
                        .wrapContentHeight()
                        .fillMaxWidth(0.8f)
                        .animateContentSize(),
...

I'll see if I can fix the problem with decorFitsSystemWindows = false invalidating layout continuously.

I just verified that an AlertDialog called from a ModalBottomSheet from a Pixel 9XL works fine. I'll see if I can find a Samsung device to test.

Yes this is specific to Samsung as stated in first message.

I repro via Samsung testlab as I do not have a device myself, but A54 A55 with Android 14 there does reproduce the issue. (And a few different other Android 14 samsung devices from my beta users)

I just verified that I can repro on a Samsung device.

Perfect.

Just quickly tested the

.fillMaxSize()
.wrapContentHeight()

And it seems to behave correctly for the dialog scrim so works as a solution, may worth a note somewhere as cheating with usePlatformDefaultWidth = false was often found as solution in a few posts over Internet.

A quick "mostly" related question to the dialog scrim, many users requested an option to hide the status bar in my app to be in full immersive mode, but there's no way to do that with dialogs right now. Is this something that can be requested? I have a fork of M3 BottomSheet to handle that, but handling a fork of the low level dialog requires a full copy and rewrite of everything that depends on it.

Have you tried using the DialogWindowProvider?:

fun findDialogWindowProviderInParent(view: View): DialogWindowProvider? {
    if (view is DialogWindowProvider) {
        return view
    }
    val parent = view.parent ?: return null
    if (parent is View) {
        return findDialogWindowProviderInParent(parent)
    }
    return null
}

@Composable
MyDialogContent() {
    val dialogWindowProvider = findDialogWindowProviderInParent(LocalView.current)
    dialogWindowProvider?.window?.addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN)
    ...
}

Not at all I always failed at finding the proper window, this works perfectly thanks a lot.

                        val dialogWindowProvider = findDialogWindowProviderInParent(LocalView.current)
                        val window = dialogWindowProvider?.window
                        if (window != null) {
                            WindowCompat.getInsetsController(window, window.decorView).apply {
                                hide(WindowInsetsCompat.Type.statusBars())
                                systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
                            }
                        }

Returning to the 2nd issue about the lag and your solution.

Using a .fillMaxSize() breaks the second .fillMaxWidth(0.8f). In my case since only the height change I can use a .fillMaxHeight() but I do not really understand what is happening. See attached screenshots.

I can just return to usePlatformDefaultWidth = true since your workaround fixes the lag and then it behave as expected.

So just reporting in case there's something else about measurement that changes and was not expected.

Ok and now the memories slowly comes back :(

1. usePlatformDefaultWidth = true and dialog resizing issues.

Use the following dialog content with the content from #4 and usePlatformDefaultWidth = true

Surface(
                            modifier = modifier
                                .safeContentPadding()
                                .fillMaxWidth(0.8f),
                            shape = shape,
                            color = backgroundColor,
                            contentColor = contentColor,
                        ) {
                            dialogNavigator.SaveableState("currentDialog") {
                                dialogContent(dialogNavigator)
                            }
                        }

It gives the result plaformnoanimate.png attached.

With

 Surface(
                            modifier = modifier
                                .safeContentPadding()
                                .animateContentSize(),
                            shape = shape,
                            color = backgroundColor,
                            contentColor = contentColor,
                        ) {
                            dialogNavigator.SaveableState("currentDialog") {
                                dialogContent(dialogNavigator)
                            }
                        }

It gives the result platformanimate.png

Both are wrong as the dialog does not properly resized on content change, strangely I can't find the issue on the tracker but I'm pretty sure there was one opened about that since ages and the reasons we had to migrate to use usePlatformDefaultWidth = false. Those hacks are so old on my side that I have an hard time remembering all the details :(

2. .fillMaxSize() breaks the dismissOnClickOutside

As per this item title, adding the fillMaxSize prevent click outside to dismiss the dialog so it not really a proper workaround.

All those tests are made with alpha 4 that contains the CL.

Adding a final note if anyone reads and needs a solution.

                        Box(
                            modifier = Modifier
                                .safeDrawingPadding()
                                .fillMaxSize()
                                .padding(horizontal = 32.dp)
                                .clickable {
                                    if (dialogState.canDismiss.value) {
                                        dialogNavigator.hide()
                                    }
                                }
                        ) {
                            Surface(
                                modifier = modifier
                                    .align(Alignment.Center)
                                    .sizeIn(maxWidth = 640.dp)
                                    .clickable(enabled = false) {}
                                    .animateContentSize(),
                                shape = shape,
                                color = backgroundColor,
                                contentColor = contentColor,
                            ) {
                                dialogNavigator.SaveableState("currentDialog") {
                                    dialogContent(dialogNavigator)
                                }
                            }
                        }

Beware that this still only works properly with usePlatformDefaultWidth = false

See resulting video "works"

With usePlatformDefaultWidth = true this will give the result "notwork" where the dialog width animate (while it should not, the actual width never changes) but the content does not seems to react so the title is on 2 lines. (The title is a simple Text() present on first display, not a later change)

I think I covered most of the issues with dialogs here. Some very old that where workarounded via usePlatformDefaultWidth=false and some that are now also present in usePlatformDefaultWidth=false due to window resizing (But working better than the other case)

Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <mount@google.com>
Link:      https://android-review.googlesource.com/3312260

Set default Gravity for Dialogs to CENTER

Set default Gravity for Dialogs to CENTER

Fixes: 373093006

On some devices, the default gravity for dialogs is not CENTER.
This changes the default gravity for Compose dialogs to CENTER.

Test: new test, manual testing on broken device
Change-Id: Ia2ec9f6edc2705cb8a13201d5e05a859a6bb9571

Can we discuss the other issues too?

I guess that's a no and I documented all the issues for nothing.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.ui:ui:1.8.0-alpha05
• androidx.compose.ui:ui-android:1.8.0-alpha05
• androidx.compose.ui:ui-jvmstubs:1.8.0-alpha05
• androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha05