Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppEngineCredentialStore should "un-index" property fields #31

Closed
wonderfly opened this issue Jan 9, 2015 · 11 comments
Closed

AppEngineCredentialStore should "un-index" property fields #31

wonderfly opened this issue Jan 9, 2015 · 11 comments
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From steve.zi...@bettercloud.com on March 31, 2012 06:48:57

With datastore writes costing a premium on Google App Engine, property fields not needing indexes (accessToken, refreshToken, and maybe expirationTimeMillis) should be set with entity.setUnindexedProperty().

Original issue: http://code.google.com/p/google-oauth-java-client/issues/detail?id=31

@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on July 14, 2012 04:50:43

Status: Accepted
Cc: yan...@google.com
Labels: Milestone-Version1.12.0 Component-OAuth2

@wonderfly
Copy link
Contributor Author

From yan...@google.com on September 26, 2012 05:18:05

Owner: ngmic...@google.com
Cc: rmis...@google.com

@wonderfly
Copy link
Contributor Author

From yan...@google.com on October 08, 2012 12:17:51

Labels: -Milestone-Version1.12.0 Milestone-Version1.13.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on December 01, 2012 09:31:43

Labels: -Milestone-Version1.13.0 Milestone-Version1.14.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on February 04, 2013 20:47:33

Labels: -Milestone-Version1.14.0 Milestone-Version1.15.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on April 19, 2013 19:18:22

Owner: yan...@google.com
Cc: -yan...@google.com -rmis...@google.com ngmic...@google.com pele...@google.com
Labels: -Type-Defect Type-Enhancement

@wonderfly
Copy link
Contributor Author

From yan...@google.com on April 20, 2013 06:31:44

Owner: pele...@google.com
Cc: -pele...@google.com yan...@google.com

@wonderfly
Copy link
Contributor Author

From yan...@google.com on April 22, 2013 14:28:37

Labels: -Milestone-Version1.15.0 Milestone-Version1.16.0

@wonderfly
Copy link
Contributor Author

From pele...@google.com on April 23, 2013 07:37:59

setUnindexedProperty works as well (and it's actually better then using setProperty).
But we think to redesign our store API (including AppEngineCredentialStore), so for now we won't make this change.

@wonderfly
Copy link
Contributor Author

From yan...@google.com on June 10, 2013 06:19:32

https://codereview.appspot.com/9881043

Status: Started
Owner: yan...@google.com
Cc: -yan...@google.com pele...@google.com

@wonderfly
Copy link
Contributor Author

From yan...@google.com on June 18, 2013 17:21:48

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant