Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary DataStore based on String key and Serializable value #216

Closed
wonderfly opened this issue Jan 9, 2015 · 2 comments
Closed

Arbitrary DataStore based on String key and Serializable value #216

wonderfly opened this issue Jan 9, 2015 · 2 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From yan...@google.com on April 20, 2013 06:42:06

Let's add an abstract Store interface modeled after com.google.api.client.googleapis.subscriptions.SubscriptionStore and com.google.api.client.auth.oauth2.CredentialStore that stores arbitrary data based on a String key and a Serializable Object value. We should then provide thread safe implementations MemoryStore, JdoStore, and AppEngineStore.

This would reduce the amount of duplicate code between the implementations of CredentialStore and SubscriptionStore, which also reduces development, testing, and documentation effort. There are also a lot of bugs and missing features in the current implementations and design of JdoCredentialStore and AppEngineCredentialStore, so now is a good opportunity to redesign it. It would also enable us to add additional fields in the future without having to change the implementations.

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=216

@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on April 22, 2013 14:27:40

Labels: -Milestone-Version1.15.0 Milestone-Version1.16.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on June 18, 2013 17:23:06

https://codereview.appspot.com/9029044/

Status: Fixed
Owner: yan...@google.com
Cc: pele...@google.com

clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant