Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No source jars in maven repository #382

Closed
gissuebot opened this issue Jul 7, 2014 · 13 comments
Closed

No source jars in maven repository #382

gissuebot opened this issue Jul 7, 2014 · 13 comments
Labels

Comments

@gissuebot
Copy link

From dom.happygiraffe.net on June 06, 2009 15:16:07

The newly uploaded guice 1.0 artifacts don't have any source jars attached.  These make it much
easier to work with libraries like guice in an IDE, as plugins like m2eclipse will automatically
download the source.  Would it be possible to upload the source jars?

Original issue: http://code.google.com/p/google-guice/issues/detail?id=382

@gissuebot
Copy link
Author

From limpbizkit on June 21, 2009 19:24:12

Greg, you're our Maven guy. I'm glad we have a Maven guy!

Owner: gk5885

@gissuebot
Copy link
Author

From dom.happygiraffe.net on June 23, 2009 12:13:34

I've just been looking at the ant build (on the 2.0-maven branch).  This builds the correct source jars already
(since r467 ).  However, in order to make things maven-happy, they need to be called *-sources.jar instead of
*-src.jar.  Apart from that, they should be ready to upload to a maven repository.

diff --git a/common.xml b/common.xml
index e14901e..1e20bb0 100644
--- a/common.xml
+++ b/common.xml
@``@ -96,7 +96,7 @``@
   <target name="source.jar"
       description="Create a .jar file with sources">
     <mkdir dir="${build.dir}"/>
-    <zip destfile="${build.dir}/${ant.project.name}-${version}-src.jar">
+    <zip destfile="${build.dir}/${ant.project.name}-${version}-sources.jar">
       <fileset dir="src"/>
     </zip>
   </target>

@gissuebot
Copy link
Author

From dom.happygiraffe.net on June 23, 2009 12:14:34

Doh.  That's for the 2.0 branch, not the 1.0 branch.  That said, back-porting r467 to 1.0 along with that patch
should produce the expected results.

@gissuebot
Copy link
Author

From esko.luontola on August 17, 2009 12:38:09

There still is no -sources.jar in http://google-maven-
repository.googlecode.com/svn/repository/com/google/inject/guice/2.0/ nor in
http://google-maven-
repository.googlecode.com/svn/repository/com/google/inject/guice/1.0/

@gissuebot
Copy link
Author

From dominik.drzewiecki on November 18, 2009 03:16:43

Can anyone place the sources in maven repo for 2.0, pretty please with sugar on top?

@gissuebot
Copy link
Author

From james.ravn on December 21, 2009 13:02:05

Sources please. :-)

@gissuebot
Copy link
Author

From jigar.gosar on March 18, 2010 02:36:24

Can any one please update us on the status of this task?

@gissuebot
Copy link
Author

From james.ravn on March 25, 2010 07:57:04

I've taken the liberty to create a sources jar. Simply place this in your local repo and all should work,
~/.m2/repository/com/google/inject/guice/2.0.

Binary attachments: guice-2.0-sources.jar

@gissuebot
Copy link
Author

From stephenson.james on August 20, 2010 08:21:15

Still no sources in Maven, eh?

@gissuebot
Copy link
Author

From esko.luontola on August 25, 2010 09:16:48

Also remember to add the sources for all extensions, such as multibindings. And put them to the Maven Central repository, not only google-maven-
repository.googlecode.com

@gissuebot
Copy link
Author

From steven.benitez on November 21, 2010 13:44:05

I would also like to see source (and JavaDoc) JARs for Guice 2.0, please.

@gissuebot
Copy link
Author

From sberlin on February 19, 2011 16:28:03

This is fixed for Guice 3.0+.

Status: Fixed

@gissuebot
Copy link
Author

From LeetChief on August 18, 2013 13:28:53

anything for guice 2.0 backports? thanks for the sources-jar but would be nice to have it in mvn repo too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant