Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between gapi.auth.signIn and gapi.auth.authorize #141

Closed
wonderfly opened this issue Jan 7, 2015 · 2 comments
Closed

Inconsistency between gapi.auth.signIn and gapi.auth.authorize #141

wonderfly opened this issue Jan 7, 2015 · 2 comments

Comments

@wonderfly
Copy link
Contributor

From scaryg...@gmail.com on April 15, 2014 12:36:16

gapi.auth.signIn({
"clientid": "...",
"cookiepolicy": "...",
"requestvisibleactions": "...",
"callback": "...",
"scope": "..."
});

vs.

gapi.auth.authorize({
"client_id": "...",
"cookie_policy": "...",
"request_visible_actions": "...",
"scope": "..."
}, callback);

The use of underscores vs. no underscores is confusing. Especially since using "clientid" instead of "client_id" or vice-versa results in a fun "TypeError" that it can't access 'scope' of object null, which in this case isn't a useful message at all. I would expect both functions to accept the same parameters.

In addition the documentation at https://developers.google.com/api-client-library/javascript/reference/referencedocs should be enhance to describe gapi.auth.signIn/signOut in addition to gapi.auth.authorize

Original issue: http://code.google.com/p/google-api-javascript-client/issues/detail?id=141

@wonderfly
Copy link
Contributor Author

From scaryg...@gmail.com on April 15, 2014 12:40:42

Also raised this issue in the google-plus-platform tracker since not entirely sure which team should handle this: https://code.google.com/p/google-plus-platform/issues/detail?id=814

@vidyai
Copy link
Collaborator

vidyai commented Mar 30, 2021

Thanks for reaching out. This bug tracker is intended to report bugs in the Google API JavaScript Client. For support with Google Identity issues, please see https://developers.google.com/identity; if you still need help, ask a question on Stack Overflow under the google-oauth tag.

@vidyai vidyai closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants