Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceRequests should be able to specify a value for the ?alt query parameter #193

Closed
GoogleCodeExporter opened this issue Apr 14, 2015 · 4 comments
Assignees

Comments

@GoogleCodeExporter
Copy link

When using a ServiceRequest there's no way to specify a value for the alt query 
parameter.

This parameter would be correctly handled by the IRequest instantiated inside 
ServiceRequest.BuildRequest if ServiceRequest had a publicly accessible 
ReturnType property:

http://code.google.com/p/google-api-dotnet-client/source/browse/Src/GoogleApis/A
pis/Requests/ServiceRequest.cs#125

Original issue reported on code.google.com by ccherub...@google.com on 7 Mar 2012 at 11:42

@GoogleCodeExporter
Copy link
Author

Original comment by asky...@google.com on 25 Apr 2012 at 8:53

  • Added labels: Component-Api, Milestone-Future, Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

More generally, it would be really good to generalize this to support all 
service-level parameters.  For example for YouTube:

https://www.googleapis.com/discovery/v1/apis/youtube/v3/rest?fields=parameters

{
type: "string",
description: "Data format for the response.",
default: "json",
enum: [
"json"
],
enumDescriptions: [
"Responses with Content-Type of application/json"
],
location: "query"
},
fields: {
type: "string",
description: "Selector specifying which fields to include in a partial 
response.",
location: "query"
},
key: {
type: "string",
description: "API key. Your API key identifies your project and provides you 
with API access, quota, and reports. Required unless you provide an OAuth 2.0 
token.",
location: "query"
},
oauth_token: {
type: "string",
description: "OAuth 2.0 token for the current user.",
location: "query"
},
prettyPrint: {
type: "boolean",
description: "Returns response with indentations and line breaks.",
default: "true",
location: "query"
},
quotaUser: {
type: "string",
description: "Available to use for quota purposes for server-side applications. 
Can be any arbitrary string assigned to a user, but should not exceed 40 
characters. Overrides userIp if both are provided.",
location: "query"
},
userIp: {
type: "string",
description: "IP address of the site where the request originates. Use this if 
you want to enforce per-user limits.",
location: "query"
}
}

Currently in practice these are all a generic list of parameters that apply 
across all APIs, but in theory we reserve the right to add service-specific 
parameters in the future.  In that case, we need the code generator to generate 
a property for each parameter.

Original comment by yan...@google.com on 26 Dec 2012 at 9:29

@GoogleCodeExporter
Copy link
Author

Original comment by pele...@google.com on 28 Dec 2012 at 2:09

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

see https://codereview.appspot.com/7012049 for more details

Original comment by pele...@google.com on 1 Feb 2013 at 3:22

  • Changed state: Fixed
  • Added labels: Milestone-Release1.3
  • Removed labels: Milestone-Future

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@jskeet jskeet removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants