Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/binary: missing uintX cases in intDataSize #8956

Closed
CAFxX opened this issue Oct 18, 2014 · 5 comments
Closed

encoding/binary: missing uintX cases in intDataSize #8956

CAFxX opened this issue Oct 18, 2014 · 5 comments
Milestone

Comments

@CAFxX
Copy link
Contributor

CAFxX commented Oct 18, 2014

The reflect slow path showed up in pprof for a uint64 data type:
https://code.google.com/r/cafxx-golang/source/detail?r=20d0244f15dc2584b540c90437f70ce7ab840219
@ianlancetaylor
Copy link
Contributor

Comment 1:

Thanks.  Feel like sending in a change as described at
http://golang.org/doc/contribute.html?

Labels changed: added repo-main, release-go1.5.

Status changed to Accepted.

@CAFxX
Copy link
Contributor Author

CAFxX commented Oct 27, 2014

Comment 2:

The overhead imposed by your contribution guidelines is way off the scale I'm willing to
invest in this, sorry.

@Stantheman
Copy link
Contributor

Comment 3:

I also encountered this issue when profiling my code for uint32s. I've followed the
outlines in the "Contribution Guidelines" file and have created a CL for submission:
https://golang.org/cl/171120043

@gopherbot
Copy link

Comment 4:

CL https://golang.org/cl/171120043 mentions this issue.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@Stantheman
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants