Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: decide whether to keep Pool #6984

Closed
rsc opened this issue Dec 18, 2013 · 8 comments
Closed

sync: decide whether to keep Pool #6984

rsc opened this issue Dec 18, 2013 · 8 comments
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Dec 18, 2013

We're going to add Pool early in the 1.3 cycle, but we should decide toward the end
whether it has been useful enough to stay.
@rsc
Copy link
Contributor Author

rsc commented Dec 18, 2013

Comment 1:

Also decide whether package sync is the right place.

@robpike
Copy link
Contributor

robpike commented Dec 18, 2013

Comment 2:

Also delete the words about "experimental" if we decide to keep it.

@robpike
Copy link
Contributor

robpike commented Dec 18, 2013

Comment 3:

Labels changed: added repo-main.

@gopherbot
Copy link

Comment 4 by Jens.Alfke:

+1. In developing the Couchbase Sync Gateway we've run into several situations where it
was difficult to cache expensive resources without bloating the GC heap. A GC-aware
cache like Pool would really help. (Haven't tried it yet, as we're still developing on
Go 1.2.) Please release it in 1.3.

@gopherbot
Copy link

Comment 5 by voidlogic7:

I've been using sync.Pool in my personal projects and it has been a huge performance
win. For me this has shifted the line where I decided what I can code in C and what I
can code in Go farther to Go's favor. If I revert from pool I see massive degradation
including an order of magnitude greater heap usage and what I think are GC pauses. Of
course I would never actually do that and if this went away I could still use some of
the custom pool's I used to use (or write in C), but their performance doesn't compare
favorably due to lack of thread-local pooling.

@gopherbot
Copy link

Comment 6 by uldericofilho:

I am the author of Gobloomd. I have been working on optimisations, among them the use of
pool of resources (sync.Pool).

@rsc
Copy link
Contributor Author

rsc commented Apr 3, 2014

Comment 7:

sync.Pool is being kept. issue #7167 reminds us to make sure the docs are clear about
when it should be used (Rob to write the docs).

@rsc
Copy link
Contributor Author

rsc commented Apr 3, 2014

Comment 8:

Status changed to Fixed.

@rsc rsc added fixed labels Apr 3, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants