Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: add cgo disabled mode to builders #4795

Closed
davecheney opened this issue Feb 12, 2013 · 12 comments
Closed

dashboard: add cgo disabled mode to builders #4795

davecheney opened this issue Feb 12, 2013 · 12 comments
Labels
FrozenDueToAge

Comments

@davecheney
Copy link
Contributor 

Builders should test both cgo enabled and disabled modes (where applicable). My
suggestion is cgo is triggered via a flag in the build key. So where we have linux-amd64
today, we would add a second, say linux-amd64-cgo, which can be run serially, or in
parallel, or farmed off to another builder. 

For clarification, the -cgo suffix indicates turing cgo off. Other suggestions are
welcome.
@adg
Copy link
Contributor

adg commented Feb 12, 2013

Comment 1:

And so these builders would need a separate key for linux-amd64-cgo? Or would the
dashboard be made aware of this too?

@davecheney
Copy link
Contributor Author

Comment 2:

Yeah, I think this would mean creating keys for builds (not builders) that should be
performed with cgo disabled. Although it would make the dashboard wider, it means we can
reuse the 'build multiple build keys' logic. How does that sound ?

@adg
Copy link
Contributor

adg commented Feb 12, 2013

Comment 3:

I think that should be ok.

@minux
Copy link
Member

minux commented Feb 12, 2013

Comment 4:

i think we just need to do this:
1. add -all to all.bash:
CGO_ENABLED=0 && exit 0 # some ports don't support cgo
export CGO_ENABLED=0
./make.bash --no-clean
./run.bash
2. add a flag for builder to invoke all.bash with -all.

@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 5:

[The time for maybe has passed.]

@davecheney
Copy link
Contributor Author

Comment 6:

After Go 1.1

Labels changed: added priority-later, removed priority-triage.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 7:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 8:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 9:

Labels changed: added repo-tools.

@bradfitz
Copy link
Contributor

bradfitz commented Sep 4, 2014

Comment 10:

Labels changed: added builder.

@gopherbot
Copy link

Comment 11:

CL https://golang.org/cl/138090043 mentions this issue.

@bradfitz
Copy link
Contributor

bradfitz commented Sep 4, 2014

Comment 12:

This issue was closed by revision golang/tools@8c30c1b.

Status changed to Fixed.

bradfitz added a commit to golang/build that referenced this issue Jan 21, 2015
@bradfitz
dashboard/env: add a cgo-disabled Linux builder
a6aeb3f 
I think this is all that's needed?

Fixes golang/go#4795

LGTM=adg, dave
R=adg, dave
CC=golang-codereviews
https://golang.org/cl/138090043
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bradfitz @davecheney @rsc @minux @adg @gopherbot