Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/build/dashboard: email notify on subrepo breakages #2911

Open
adg opened this issue Feb 8, 2012 · 10 comments
Open

x/tools/build/dashboard: email notify on subrepo breakages #2911

adg opened this issue Feb 8, 2012 · 10 comments
Milestone

Comments

@adg
Copy link
Contributor

adg commented Feb 8, 2012

Send mail when a sub-repository fails to build.
@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 1:

[The time for maybe has passed.]

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 2:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-tools.

@adg adg self-assigned this Dec 4, 2013
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title dashboard: email notify on subrepo breakages x/tools/dashboard: email notify on subrepo breakages Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@adg adg removed their assignment May 27, 2016
endocrimes added a commit to hashicorp/nomad that referenced this issue Jul 22, 2019
There's a bug in go1.11 that causes some io operations on windows to
return incorrect errors for some cases when Stat-ing files. To avoid
upgrading to go1.12 in a point release, here we loosen up the cases
where we will attempt to create fifos, and add some logging of
underlying stat errors to help with debugging.
@odeke-em
Copy link
Member

odeke-em commented Jun 6, 2020

Kindly looping in @dmitshur @andybons @cagedmantis @toothrot.

Could we perhaps get subrepo failures to report to a public mailing list that folks can subscribe to, perhaps golang-builds, and CC the CL authors? It’s been 8 years and we’ve lived without this functionality, but would be nice to auto report these failures indeed, as Andrew Gerrand suggested, instead of folks having to manually look at the build screens. Or does such functionality already exist? Thank you.

@odeke-em odeke-em changed the title x/tools/dashboard: email notify on subrepo breakages x/tools/build/dashboard: email notify on subrepo breakages Jun 6, 2020
@toothrot
Copy link
Contributor

This functionality does not exist. I agree that build breakage notifications are a good idea. Those of us working on the build infrastructure are currently focusing on stability and reliability of releases, which definitely feels related, but I do not know when we will be able to commit to taking on this specifically.

@ianlancetaylor
Copy link
Contributor

Just a note that a problem with e-mail based notifications is that it's very easy for them to trigger too often. People then routinely ignore them, and they serve no useful purpose. So if we do try to implement this, it's essential to minimize the number of messages, and to only send them when we are really certain that something has gone really wrong, and that we aren't just seeing flakiness.

Just as an example, perhaps it would be appropriate to send an e-mail message if a build fails five times in a row and there is some similarity in the output log for the failing builds.

2opremio pushed a commit to 2opremio/go that referenced this issue Aug 25, 2020
…and participants. (golang#2911)

* Add StringCanonical() to xdr.Asset.

* Ingest OperationTypeCreateClaimableBalance.

* Ingest  CreateClaimableBalanceOp participants.

* Ingest ClaimClaimableBalance Operation Details and Participants.

* Simplify StringCanonical test.

* Rewrite StringCanonical test.
@bcmills
Copy link
Contributor

bcmills commented Aug 30, 2021

In the absence of automated alerts, checking the subrepo build status should probably be part of some kind of periodic triage rotation, so that we don't build up a large number of regressions unnoticed during the release cycle.

@golang/release, is there an existing rotation checklist that this could be added to?

@bcmills
Copy link
Contributor

bcmills commented Aug 30, 2021

(For a recent example, #48078 during the current cycle appears to have gone unnoticed for around two weeks. It's a fairly obscure regression, so it isn't surprising that it wouldn't be noticed unless someone is actively keeping an eye on the dashboard.)

@toothrot
Copy link
Contributor

toothrot commented Aug 30, 2021

@bcmills The x/repos are checked before cutting a release, but not as part of the release rotation itself, which is already stretched fairly thin.

I think checking before a release is important for our team to do as a last-chance sanity check before we cut a release. We typically start paying closer attention a few days before we know a release is coming.

For x-repos, I still believe that it is first and foremost the responsibility of the team or individual that owns the repo to be responsible for its health. The project is simply too big for us to be capable of watching everything every day. I don't think we should add more to the release rotation to make up for that, but we can guarantee that we won't release something that we know is broken.

I think the best solution here is improved tooling for detecting regressions, which I am sure is an uncontroversial thing to say, but it is unclear when we may be able to provide it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants