Bug: “Uncaught TypeError: Cannot read property 'x' of undefined” only in Android/iOs browsers [35824357]

Fixed

Bug

Status Update

No update yet.

Description

aa...@gmail.com

created issue #1

Feb 1, 2014 12:02AM

Hi,

I'm getting the below error most of the times on every attempt to drag the map, after displaying a dynamically constructed polygon.

Error : "Uncaught TypeError: Cannot read property 'x' of undefined" 

To replicate my problem :
1. Disable the map's draggable attribute
2. Allow user to trace a shape on the map, use the coordinates to dynamically construct and show a polyline.
3. When the tracing is done, construct a polygon using the path set to the above polyline and remove the polyline
4. Enable the map's draggable attribute
5. Now try to drag the map
Error/Consequence : The above mentioned error is displayed on the browser console several times. The map is not draggable.

jsFiddle : <a rel="nofollow" href="

http://jsfiddle.net/tzpXQ/14/">

http://jsfiddle.net/tzpXQ/14/</a>
(If using this jsFiddle, click on "Start Drawing" and trace on the map to display the polyline followed by the polygon. Now try to drag the map)

On Android browser, the error points to line# 180 of my html file (irrespective of the html file length) (but I cant check what that line is)
On the iPad emulation of Chrome on desktop, the error points to the below line of a google maps API js file (whose name changes on every page load). The error line is :

<code>g("center");H.bh=cg("center");H.Gf=bg("latLngCenter");H.ph=bg("projectionBounds");H.Df=bg("projection");H.getLatLngBounds=md("k");H.Hm=bg("fixedPoint");function lx(a,b){this.min=a;this.max=b}function mx(a,b){return b<a.min?a.min:b>a.max?a.max:b};function nx(a){this.d=a}L(nx,P);nx[F].immutable_changed=function(){var a=this,b=a.get("immutable"),c=a.b;b!=c&&(Id(a.d,function(d){(c&&c[d])!==(b&&b[d])&&a.set(d,b&&b[d])}),a.b=b)};function ox(a,b,c){Bn(this,a);this.b=b;

this.ca=c}function px(a,b,c){this.x=a||0;this.y=b||0;this.b=c||1}px[F].transform=function(a,b,c){var d=c.b/b.b;this.b=a.b*d;this.x=a.x*d+(c.x-b.x*d);this.y=a.y*d+(c.y-b.y*d)};function qx(a,b){a.x-=(1-a.b)*b.x;a.y-=(1-a.b)*b.y}function rx(a,b){a.b=b.b;a.x=b.x;a.y=b.y}px[F].set=function(a,b,c){this.b=c;this.x=a;this.y=b};Na(px[F],function(){this.b=1;this.y=this.x=0});Aa(px[F],function(){return"("+this.x+","+this.y+","+this.b+")"});</code>

Browser & OS used:
1) Android browser on Android phone/tablet
2) iPad emulation of Chrome browser on desktop (closest I could get to an iPad+Mac combination)

API version :
Latest google maps API version (3.exp)

Temporary fix :
Introducing a delay of 1500ms before performing step #4 above is helping eliminate the map freezing and the error in the console, but makes the appln feel slower than it truly is.

Thanks in advance.

*********************************************************
For developers viewing this issue: please click the 'star' icon to be
notified of future changes, and to let us know how many of you are
interested in seeing it resolved.
*********************************************************

Comments

aa...@gmail.com <aa...@gmail.com> #2Feb 1, 2014 12:12AM

Tentatively, the annotation should be something use-case-specific like @OutlinedNewApi that allows alternative build systems (e.g. not R8/D8) to make their own decisions. We'll provide a default Proguard configuration for R8, but it's not guaranteed this will work as intended -- outlining is automatic in newer versions, but it may be disabled.

ka...@gmail.com <ka...@gmail.com> #3Feb 7, 2015 08:50PM

Just as an FYI, this was enabled in AGP 2 years ago (AGP 7.3 as far as I remember), ag/18426192, so for AGP users it might fine to just remove the rule for @DoNotInline. I like the @OutlinedNewApi to make it clear what this is for other consumers to handle it as they see fit.

[Deleted User] <[Deleted User]> #4May 7, 2015 01:50PM

This article from Morten Krogh-Jespersen suggests it wasn't (perma-)enabled by default until AGP 8.1, which is only <redacted>% of users.

Given the failure mode can include run-time crashes, that's not an acceptable level of usage.

de...@gmail.com <de...@gmail.com> #5May 27, 2015 10:07PM

I think you can still include a top-level proguard.txt, and it will be used by versions that do not support the com.android.tools format. E.g. Kotlin Coroutines library does this

de...@gmail.com <de...@gmail.com> #6May 27, 2015 10:18PM

Yeah, I that combined with r8-upto is the right approach. comment#4 is in regard to the idea that we should remove the annotations from source instead of gating the rules on R8 version.

en...@google.com <en...@google.com> #7May 28, 2015 01:12AM

Accepted by zw...@google.com.

Looping in from offline, any new libraries require a high enough compileSdk that we're going to see a recent-enough AGP. So, we should just remove our manual outlining and use of @DoNotInline.

cs...@google.com <cs...@google.com> #8Jun 19, 2015 05:45AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0c5446468c1e1fc08b1cea04dc57b05c52417ce8
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 13:50:59 2024

Disable class verification failure lint checks

They are no longer needed since we transitively require AGP 8.1.

Bug: 345472586
Test: ./gradlew lintDebug
Change-Id: Icb6ad18297fef4a23071cd849b6e84855d2becd0

M lint-checks/src/main/java/androidx/build/lint/AndroidXIssueRegistry.kt

https://android-review.googlesource.com/3156137

cs...@google.com <cs...@google.com> #9Jun 26, 2015 01:19AM

Project: platform/frameworks/support
Branch: androidx-main

commit 722ebe758557abaf7409c052bb2f326782369c84
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:05:38 2024

Remove usage of @DoNotInline for manual NewApi outlines (R thru W)

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: Ia60e0ab9f0fd613883a772c8aa34e27cc986cae8

M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/GridLayoutManager.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/MainActivity.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/systemrouting/source/AudioManagerSystemRoutesSource.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/player/Player.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/providers/SampleMediaRouteProvider.java
M security/security-crypto/src/main/java/androidx/security/crypto/MasterKey.java
M security/security-identity-credential/src/main/java/androidx/security/identity/HardwareIdentityCredential.java
M slice/slice-core/src/main/java/androidx/slice/Slice.java
M slice/slice-core/src/main/java/androidx/slice/compat/SliceProviderCompat.java
M sqlite/sqlite-framework/src/androidMain/kotlin/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.android.kt
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/AccessibilityNodeInfoDumper.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/ByMatcher.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/UiDevice.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/UiObject2.java
M testutils/testutils-runtime/src/main/java/androidx/testutils/AndroidFontScaleHelper.kt
M text/text/src/main/java/androidx/compose/ui/text/android/BoringLayoutFactory.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/PaintExtensions.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/StaticLayoutFactory.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextAndroidCanvas.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/selection/SegmentFinder.android.kt
M tracing/tracing/src/main/java/androidx/tracing/TraceApi29Impl.java
M transition/transition/src/main/java/androidx/transition/CanvasUtils.java
M transition/transition/src/main/java/androidx/transition/GhostViewHolder.java
M transition/transition/src/main/java/androidx/transition/ImageViewUtils.java
M transition/transition/src/main/java/androidx/transition/ObjectAnimatorUtils.java
M transition/transition/src/main/java/androidx/transition/PropertyValuesHolderUtils.java
M transition/transition/src/main/java/androidx/transition/Transition.java
M transition/transition/src/main/java/androidx/transition/TransitionUtils.java
M transition/transition/src/main/java/androidx/transition/ViewGroupUtils.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi19.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi21.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi22.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi23.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimatedVectorDrawableCompat.java
M versionedparcelable/versionedparcelable/src/main/java/androidx/versionedparcelable/VersionedParcel.java
M wear/protolayout/protolayout-expression-pipeline/src/main/java/androidx/wear/protolayout/expression/pipeline/NumberFormatter.java
M wear/tiles/tiles/src/main/java/androidx/wear/tiles/TileService.java
M wear/watchface/watchface-complications-data/src/main/java/androidx/wear/watchface/utility/TraceEvent.kt
M wear/wear-remote-interactions/src/main/java/androidx/wear/remote/interactions/RemoteInteractionsUtil.kt
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForM.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForN.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForO.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForOMR1.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForP.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForQ.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForTiramisu.java
M window/window/src/main/java/androidx/window/embedding/ExtensionEmbeddingBackend.kt
M window/window/src/main/java/androidx/window/embedding/SplitRule.kt
M window/window/src/main/java/androidx/window/layout/util/ContextCompatHelper.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableRuntimeExtras.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundService.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/DurationApi26.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi21.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi23.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi24.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkRequestCompat.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/ProcessUtils.kt

https://android-review.googlesource.com/3156141

[Deleted User] <[Deleted User]> #10Mar 23, 2016 07:40PM

Project: platform/frameworks/support
Branch: androidx-main

commit a3c2cdfa79630ce1b6ccfae79068b331bd86889f
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:07:44 2024

Remove fully-qualified usages of @DoNotInline for manual NewApi outlines

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: I5921633fee80fcbc2c6ee05cb94f5fab0b9a6daf

M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidGraphicsContext.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPaint.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidRenderEffect.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV23.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV29.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsViewLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerManager.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerSnapshot.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi29.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.android.kt
M graphics/graphics-core/src/main/java/androidx/graphics/CanvasBufferedRendererV29.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/BufferTransformHintResolver.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/FrontBufferUtils.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/LowLatencyCanvasView.kt
M graphics/graphics-core/src/main/java/androidx/graphics/surface/SurfaceControlCompat.kt
M graphics/graphics-core/src/main/java/androidx/graphics/surface/SurfaceControlV33.kt
M graphics/graphics-core/src/main/java/androidx/hardware/SyncFenceCompat.kt
M leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionsStylist.java

https://android-review.googlesource.com/3156142