Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #294

Merged
merged 2 commits into from Aug 7, 2015
Merged

Develop #294

merged 2 commits into from Aug 7, 2015

Conversation

WilliamFromTW
Copy link
Contributor

tranditional chinese translation
it's for zh_TW(Taiwan)

@gitblit
Copy link
Collaborator

gitblit commented Aug 7, 2015

👍 This looks good. I need one small change to merge: we need to add a new choice to the languages array. I temporarily hacked it in for my test - but I don't know what the appropriate label should be.

https://github.com/gitblit/gitblit/blob/develop/src/main/java/com/gitblit/wicket/pages/UserPage.java#L186

@WilliamFromTW
Copy link
Contributor Author

sorry i forgot add language choice.

original in gitblit could be
new Language("中文", "zh_CN")
or
new Language("簡體中文", "zh_CN")
"簡體中文" means Simplified Chinese

In taiwan we use tranditional chinese(means 正體中文)
should be
new Language("正體中文", "zh_TW")

thanks

gitblit added a commit that referenced this pull request Aug 7, 2015
Add traditional Chinese translation
@gitblit gitblit merged commit 03734ab into gitblit-org:develop Aug 7, 2015
@flaix flaix modified the milestone: 1.7.0 Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants