Issue 842: Something weird going on with blank lines
Status:  Duplicate
Merged:  issue 833
Owner: ----
Closed:  May 2011
Reported by fad...@google.com, Feb 14, 2011
Affected Version: (2.1.6.1-49-gd1a8369)

Not sure exactly what's going on.  In short:

- regenerate Dalvik mterp sources (vm/mterp/out) with python script
- commit and submit changes

I've had a couple of weird instances of blank lines not quite being preserved.  I noticed this while working on:

  https://android-git.corp.google.com/g/#change,96594

This included InterpAsm-x86-atom.S, which has only one change (an extra blank line).  This isn't totally uncommon -- the stuff in vm/mterp/out is generated in a non-build step, and we don't build x86-atom, so sometimes minor tweaks get lost.  I didn't think anything of it.

Then I posted the change for review.  The InterpC-allstubs.c file shows an extra "/*" on line 3123, but that wasn't part of the change.  I made a note of this in gerrit and told my reviewers to ignore it.

Then I submitted the change.  It appears that the /* on line 3122 was replaced with a blank line.  If I regenerate the InterpC-allstubs.c file, I now have a one-line diff, showing the blank line being deleted.

My first thought was that this was a bug in gerrit diff, but it seems to be having an impact on the checked-in code.

I'm working on a standard Linux desktop config.

May 20, 2011
Project Member #1 nas...@grainawi.org
Looks to be the same as 833.
Status: Duplicate
Mergedinto: 833