Issue 573: Extra characters appear after change URL
Status:  Invalid
Owner: ----
Closed:  May 2010
Reported by kevin.d...@gmail.com, May 19, 2010
Affected Version: 2.1.2.4

What steps will reproduce the problem?

1. git push --receive-pack='git receive-pack --reviewer=kdegi'
ssh://review.server.com:29418/project.git HEAD:refs/for/master

What is the expected output? What do you see instead?

Expected:

remote: 
remote: New Changes:
remote:   https://review.server.com/25307
remote: 
To ssh://review.server.com:29418/project.git
 * [new branch]      HEAD -> refs/for/master


Actual:


remote: 
remote: New Changes:
remote:   https://review.server.com/25307
remote: 
To ssh://review.server.com:29418/project.git
 * [new branch]      HEAD -> refs/for/master

Please provide any additional information below.

The additional characters do not get printed in most terminals, but output
will fail to match "grep '[[:digit:]]+$'. They are also visible if a file
with the output is opened with vi.
May 19, 2010
#1 sop@google.com
What version of git was your client?

I suspect this is a problem with git, not with Gerrit.  Those extra characters are 
actually terminal escape sequences to try and reset the output of your tty to be 
sane, in case the remote server (Gerrit Code Review) used tty escapes to color text 
or disable echoing and didn't reset back to the defaults.

Since you mention these show up in a file, it sounds like your git is treating the 
redirected stderr as though it were a tty, not a file/pipe.  I'll try to look at this 
over in git itself, its probably my code that is wrong.  But I'm marking this as 
Invalid for Gerrit Code Review because its not a bug in Gerrit.
Status: Invalid
Labels: git-core
May 19, 2010
#2 kd...@codeaurora.org
git --version
git version 1.7.0.5
May 19, 2010
#3 kd...@codeaurora.org
Also, we began seeing the issue after we upgraded Gerrit on Sunday (5/16). It was 
working correctly on the Friday before the upgrade. We have not changed the version of 
git we are running.
May 19, 2010
#4 sop@google.com
You upgraded your Gerrit server to a version that supports pushing the messages over 
the sideband channel rather than over the stderr pipe of the SSH connection.

The bug is still in git itself, for including tty reset characters when decoding
the sideband channel to a non-tty stderr channel.