Issue 551: Improve the diff viewer between Patch Sets with different parents
Status:  Duplicate
Merged:  issue 217
Owner: ----
Closed:  Jun 2010
Reported by di...@google.com, Apr 28, 2010
When a user has a pending change for review and a commit happens at the 
same time in the Gerrit repository and the user updates the change with a 
second Patch Set that has some changes to address the reviewer's concerns 
but also is rebased on the new tip of the Gerrit branch then viewing 
differences between patch sets will also display the differences introduced 
by the commit on the Gerrit tree.

I understand why this is happening right now but can be confusing for 
reviewers. As a first step it might help to display a warning when viewing 
differences between Patch Sets with different parents so reviewers are 
aware of the issue.

Another improvement would be to try to rebase the old Patch Set 
automatically on the new parent and if that works display the diff between 
that and the second Patch Set. If git rebase fails then just display that 
warning.

Even better, if something like the git rebase approach is done then it 
would help to make it visible to the reviewer what's going on. Say on the 
Patch History drop down show a second column of checkboxes for the rebased 
versions so the reviewer is both aware they are compare rebased old patch 
sets and also has the possibility to compare non rebased ones (wondering if 
that's needed).
Jun 10, 2010
Project Member #1 edwin.ke...@gmail.com
Issue 217 seems to be related.
Jun 10, 2010
#2 di...@google.com
Yes, it's a duplicate, the only difference I see is that I provided several other options in this bug.
Jun 10, 2010
#3 sop@google.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 217
Feb 5, 2014
#4 gust...@cpqd.com.br
I made a reference to this issue in this discussion: https://groups.google.com/d/msg/repo-discuss/jCFPnrIIdLI/vczDFrdspdcJ