Issue 51: ability to work with patchsets as well as single changes
Status:  Started
Owner: ----
Cc:

Blocking:
issue 723
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Brian Swetland <swetland@android.com> on Wed Jan 28 16:54:35 PST 2009
Source: JIRA GERRIT-51
Affected Version: 2.0

The kernel team is interested in having patches that are uploaded together be
logically grouped as a patchset to make it easier to keep track of all the
bits, make sure they're all reviewed, and ideally have a view that shows all
the changes in a patchset, if they've been approved, and allow them to be
submitted as a unit if so.

Being able to collect individual patches into a patchset would be nice too.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jan 28 17:00:30 PST 2009

This issue highlights Gerrit's own unfortunate use of the term "Patch Set".

Gerrit calls a specific revision of a specific logical change a "Patch Set".

What Brian is referring to here is the more classical Git definition of a
Patch Set.

Brian Term :: Gerrit Term
    Definition...
-------------------------------------------------------

Patch        :: Change
    A single logical change to the project

Patch Set :: List of Changes?
    More than one logical change, typically related to the introduction of a
single feature

?                :: Patch Set
    An edit revision of a logical change, e.g. after incorporating review
feedback.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Brian Swetland <swetland@android.com> on Wed Jan 28 17:06:28 PST 2009

Maybe:  Change,  ChangeList or ChangeSet, RevisedChange?

I'm fine with "Change" in general.
Sep 24, 2009
#3 sop+code@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: ---
Sep 24, 2009
#4 sop+code@google.com
(No comment was entered for this change.)
Cc: swetl...@android.com
Jul 13, 2010
#5 mhanw...@gmail.com
We would like to have the ability to review named topic branches, consisting of one of more commits, and be able to view the entire topic branch, ensure each commit is reviewed and merge in the entire branch once ready. We also use multiple integration branches, but that is another feature request.
Jul 15, 2010
#6 sop@google.com
Change I07d6c137fc9aefa8c1ee1652bf1e7bcde9d33674 adds
a topic field to the change record, and can be set at
upload time by adding it to the push command line:

  git push URL HEAD:refs/for/master/topic-name

We don't yet have a way to filter a view to show all
changes related by topic, but this is a decent start.
Status: Started
Labels: Milestone-2.1.4
Jul 16, 2010
#7 mhanw...@gmail.com
This looks like a great start, I love the syntax. Once there is a way to filter, and so view/edit all patches in a series, this would satisfy a large portion of what we need to be able to effectively use Gerrit. Very much looking forward to the next release.
Jul 18, 2010
#8 sop@google.com
2.1.4 will also have enhanced query operators.  You can search
for "branch:master topic:topic-name is:open" to find all open
changes that are for the master/topic-name.  This is actually
already installed on a few machines.
Aug 4, 2010
#9 sop@google.com
(No comment was entered for this change.)
Labels: -Milestone-2.1.4
Aug 19, 2010
#10 sop@google.com
See also issue 616 now about abandon multiple
changes (and maybe submit multiple changes).
May 20, 2011
Project Member #11 nas...@grainawi.org
(No comment was entered for this change.)
Blocking: 723
Jun 8, 2011
#12 oswald.b...@gmx.de
this project is being worked on, see https://github.com/petefoth/gerrit-topic-reviews/wiki/
Jun 20, 2011
#13 pete.fot...@gmail.com
As mentioned in the mailing list, we have been working on this for a little while, and the attached file contains information about requirements and UI. We hope to have some code to submit for review in the near future.

Our proposals add to the existing functionality so that all the commits in a topic are treated as a unit for the purposes of review and approval.
Gerrit Topic Reviews Requirements.pdf
352 KB   Download
Nov 10, 2011
#14 oswald.b...@gmx.de
this is deployed on http://codereview.qt-project.org/ now. as can be seen in our bug tracker (https://bugreports.qt.nokia.com/browse/QTQAINFRA/component/19470), it is afflicted with some rather serious issues, so we'll need a second iteration before we try upstreaming anything.
Nov 10, 2011
#15 pete.fot...@codethink.co.uk
Re: Comment 14.
Thanks for the comment. Please can you give a bit more information?

1: Which version of the topic review functionality are you working with? Did you pick up the version that was pushed to review.source.gerrit.com on 31/8/11 or have you picked up a more recent branch from the working repo on GitHub?

2: Can you tell me exactly which issues affect the topic reviews functionality? I have spotted the ones listed below, but are there any others I have missed?
https://bugreports.qt.nokia.com/browse/QTQAINFRA-366
https://bugreports.qt.nokia.com/browse/QTQAINFRA-351
https://bugreports.qt.nokia.com/browse/QTQAINFRA-352
https://bugreports.qt.nokia.com/browse/QTQAINFRA-375

Thanks

Nov 11, 2011
#16 oswald.b...@gmx.de
hi pete,

i have no clue what exactly was used. need to query mikah or marius or look into the repo later.

some other [possibly] related issues:
https://bugreports.qt.nokia.com/browse/QTQAINFRA-370
https://bugreports.qt.nokia.com/browse/QTQAINFRA-372
https://bugreports.qt.nokia.com/browse/QTQAINFRA-381

some of the most serious issues result from the fact that we merged another rather intrusive feature (CI integration) which was developed independently. our beta testing of the actual implementation wasn't too thorough, either. so we're not blaming you in any way.
it's likely that marius will follow up with you next week or so.
Nov 11, 2011
#17 oswald.b...@gmx.de
the gerrit repository doesn't reveal what exactly was merged (it's a single rebased commit without attribution), and there are several fixes on top of it. i need to bug mika, after all.

and we have a new winner ... :}
https://bugreports.qt.nokia.com/browse/QTQAINFRA-382

Nov 11, 2011
#18 marcus.h...@kitware.com
We have a test server up here,

http://reviewtest.source.kitware.com:81

I am working on getting our topic branch with fixes on top of what Code Think did, but we have already encountered and fixed a few of these issues in our internal (and now external) testing. We have several outstanding issues too, but would like to upstream our changes when feasible (as well as upgrade our main Gerrit instance).
Nov 14, 2011
#19 oswald.b...@gmx.de
pete, the branch mika integrated had 29 commits in it and ends with a3cfb3d.
Nov 18, 2013
#23 daniel.r...@gmail.com
I just tried out the branch Kitware is using.  
Here's a script to build it, configure a dummy project, and submit a topic branch for review.

The only hitch I ran into is that sometimes adding permissions to a
project doesn't work; once it gets in that state, it stays there, so
best to put the right permissions on before importing any code.
(This might just be the h2 database, I haven't tried it with a real
database yet.)

However, I've dropped the idea of using Gerrit, and am going with Gitlab instead.
(Gitlab is gorgeous, handles topic reviews out of the box, and offers a complete solution, whereas gerrit only addresses code review.)

I hear rumors that the Qt project is using a different topic review fork, don't knowo the details.
gerrit_topic_review_demo.sh
2.4 KB   View   Download
Feb 28, 2014
Project Member #25 jrn@google.com
 Issue 1722  has been merged into this issue.
Cc: mf...@codeaurora.org chris.ha...@kitware.com