Issue 499: Display diffstat of each patch file
Status:  Released
Owner: ----
Closed:  Mar 2012

Blocked on:
issue 452
Reported by wal...@google.com, Mar 15, 2010
When looking at a patch set in Gerrit, I'm seeing a table of modified files
with links to open side-by-side or unified diffs in a different browser tab.

I would like two additions to this table:

* Showing the number of added and removed lines for each file (so we can
have a quick idea of the size of the change);

* Additional link to show inline diffs: clicking this link would create a
space immediately below the line that features this link, and the unified
diff would appear in that space rather than on a separate browser tab.

These changes could make it much easier to review small patch sets, IMO.

Mar 15, 2010
#1 sop@google.com
The first part is closely related to  issue 452  which also
asks for the diffstat (added/removed line counts).

The second part of your request is a duplicate, please
see issue 22.
Summary: Display diffstat of each patch file
Status: Accepted
Blockedon: 452
Jul 20, 2010
#2 sop@google.com
 Issue 630  has been merged into this issue.
Aug 4, 2010
#3 antony.s...@gmail.com
Just want to clarify that the diff stat shown would be the delta between the patch different patch sets right? As opposed to the change as a whole (which would be visible as the diff stat of the first patch set).
Aug 4, 2010
#4 sop@google.com
I think its the delta between the commit's ancestor and
the commit itself, not between different patch sets on
the same change.
Aug 4, 2010
#5 antony.s...@gmail.com
Dang.

What's important to me, is what has changed in this latest patch-set? What does the change now look like?

I.e. whenever a new patchset comes up, I go into the diff viewer, change the comparison to latest patchset to latest-1, and hit "]" going through each file, hunting for the changes. It would very valuable to me to be able to know this straight away.

Am I alone?

Is there space to do both?
Aug 4, 2010
#6 sop@google.com
We should do both.  The other change you want is
 issue 194 .  If you had  issue 194  then the UI would
let you compare patch set 3 and patch set 4 (for
example), and only modified files would be listed,
and the diff stat would show the edits between ps 3
and ps4.

But if you compare ps 4 to the base, it would show
the diff stat for ps 4 relative to the ancestor, and
thus show the impact of the full change.

Make sense?
Aug 4, 2010
#7 antony.s...@gmail.com
Makes sense. 

But IMO it should be visible from the summary screen.

What about adding a column to the file table for the ps which shows the diffstat from the last ps?
Aug 21, 2010
#8 sop@google.com
Size column added in I961d8fac3f5d82a5d24f0a4d0b0a9ddf39182a50.
Status: Fixed
Labels: FixedIn-2.1.5
Mar 27, 2012
#9 sop@google.com
(No comment was entered for this change.)
Status: Released