Issue 478: gerrit can't start with replication.config errors
Status:  Released
Owner: ----
Closed:  Mar 2012
Reported by mike.lifeguard@gmail.com, Mar 2, 2010
Affected Version:

After an error like  issue 447  (replication failure on local urls due to
either a permission error or the repo not existing), gerrit fails to start
until replication.config is commented out. Again, simply warn in error_log
and continue along.
Mar 2, 2010
#1 mike.lifeguard@gmail.com
I should be clear - replication.config was valid, however gerrit failed to actually
accomplish the requested replication, and that is why gerrit wouldn't start.
Mar 2, 2010
#2 mike.lifeguard@gmail.com
And that should have been  issue 477 , not 447
Mar 2, 2010
#3 sop@google.com
Change I4135f3776a77d9afb32b411640d6f507a1ed4def logs the
configuration problem to the error_log, rather than having
it go to /dev/null.

I still think stopping startup due to a bad replication.config
is a good idea.  The admin has a configuration we can't use,
he should fix it before we continue.
Status: Fixed
Labels: FixedIn-2.1.2
Mar 2, 2010
#4 sop@google.com
 Issue 477  has been merged into this issue.
Mar 2, 2010
#5 mike.lifeguard@gmail.com
I guess the summary is misleading (can't immediately see how to change it) -- the
config was valid, but there was some other error (permissions or the target dir not
existing are my guesses).

When config can't be parsed, we should stop trying and make the admin fix it: output
to error_log which you've now done, then die.

However, if the config file is OK, but there is some other error with actually
replicating using that config, there's no reason to die.

I guess that is the current state of affairs, so we're done.

My apologies for a bit of a wild goose chase.
Mar 27, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released