Issue 448: Color added/removed lines in unified patch views
Status:  Released
Owner: ----
Closed:  Mar 2012
Reported by mike.lifeguard@gmail.com, Feb 13, 2010
Currently, the only indication that a line is a changed line is a *tiny*
little +/- right before it. This makes it difficult to see at a glance
where changed lines are located.

Please consider at least allowing the user to turn off syntax highlighting
(which kinda sucks anyways, but report on that to follow) and instead show
-lines as red and +lines as green.

See examples like
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/62420 for
easily-viewed diffs.
Feb 13, 2010
#1 sop@google.com
The original issue is talking about the unified patch views, its
hard to read what the state of each line is because there isn't a
coloring attached to it.

The MediaWiki example uses red text for the - lines and green text
for the + line, both on the white page background.
Summary: Color added/removed lines in unified patch views
Status: Accepted
Feb 13, 2010
#2 sop@google.com
The issue in Gerrit is, we are coloring with red/green here,
but the syntax highlighting is taking precedence over the
diff highlighting, so we lose the red/green and get instead
the colors from the syntax tokens.

It might be better to just disable syntax coloring on the
unified view entirely.
Feb 13, 2010
#3 sop@google.com
Fixed by change I994758b93e4f8b5633cd61c13911280c0bd7aafa

Syntax highlighting is now off in the unified view.
Status: Fixed
Labels: FixedIn-2.1.2
Mar 27, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released