Issue 441: User configureable keyboard shortcuts
Status:  Started
Owner: ----
Reported by anders.w...@gmail.com, Feb 9, 2010
Affected Version: 2.1.1
Environment: Firefox 3.x, any OS

What steps will reproduce the problem?

1. Enable "Search for text when I start typing" in the "Advanced" section
of Firefox's settings
2. Type-to-find a string that starts with, say, "u" in a gerrit diff view


What is the expected output? What do you see instead?

The browser should highlight the first occurrence of the typed letter in
the page. Instead, Gerrit interprets the letter as a shortcut.

For many who don't use full-blown type-to-find, I still imagine that
overriding the browser's "/" shortcut for quick find to focus Gerrit's own
search field will be an annoyance.


Please provide any additional information below.

The most obvious solution to this problem would be to add a toggle for
keyboard shortcuts on the Preferences page.
Feb 10, 2010
#1 sop@google.com
(No comment was entered for this change.)
Summary: Add preference to enable/disable keyboard shortcuts
Status: Accepted
Feb 14, 2010
#2 anders.w...@gmail.com
I uploaded a patch that adds the functionality to
https://review.source.android.com/#change,13532 but after I was done I realized that
I forgot to investigate how to make the database change I added upgradeable.

It seems to work as intended for a fresh install, though.
Feb 15, 2010
#3 sop@google.com
Thanks for the patch.  I'm not going to bother commenting on the
patch directly, but instead will stick my general thoughts here.
       
I also have an open feature request to let the user choose their
own keyboard shortcuts.  I just failed to document it as an issue
here in the issue tracker.  Given that request, I think it makes
sense to implement the enable/disable keyboard shortcuts as just
another shortcut map which bindings no keystrokes at all.
       
So what I would prefer to see is we change gwtexpui's GlobalKey
to create a binding of each KeyCommand to be a command identity,
and then configure a separate map that binds shortcuts to identities.
       
Within the account preferences, we store instead of a boolean the
name of the key binding map.  And we provide at least two stock
maps, one that is the current binding table, and one that is totally
empty and therefore would disable all shortcuts.
       
This should simplify a lot of the UI code, because we no longer
have to do conditionals around each keyboard shortcut setup site.
 
Also, two minor style nits about your commit message.  Please try
to keep the first line under 70 characters.  So I would suggest
maybe using a subject of "Implement configurable keyboard shortcut
bindings" for the revised patch.  Second, please include a line 
just before Change-Id of "Bug: issue 441\n" to link back to this
issue in the issue tracker.
Status: Started
Feb 15, 2010
#4 anders.w...@gmail.com
That certainly sounds like a better way to do it. I guess poking around in gwtexpui
will be my next weekend project (I assume it's the one from android.git.kernel.org).

And thanks for the Gerrit etiquette tips :)
Feb 15, 2010
#5 sop@google.com
Yea, gwtexpui is in the tools directory on android.git.kernel.org.
Aug 26, 2010
#6 sop@google.com
 Issue 692  has been merged into this issue.
Aug 26, 2010
#7 sop@google.com
(No comment was entered for this change.)
Summary: User configureable keyboard shortcuts
Jun 23, 2011
#8 daniel.l...@packetfront.com
I would also like to see this at some time, using the shortcuts is a pain/does not work (like [ and ] which I tend to use the most) with a non US keymap.