Issue 379: When new patch sets are generated, mark the files that are different from the previous patch set
Status:  Accepted
Owner: ----
Cc:
scro...@google.com

Blocked on:
issue 194
Reported by alex.ble...@gmail.com, Jan 7, 2010
I've reviewed a couple of changes where a patch set has been identical to the previous, although 
it's got different IDs. For example

http://egit.eclipse.org/r/#patch,sidebyside,177,2,org.eclipse.jgit.test/tst/org/eclipse/jgit/util/Te
mporaryBufferTest.java

There's no differences between patch set 1 and patch set 2 - and I've already reviewed patch set 1. 
Ideally we wouldn't have a patch set 2 at all - but in the case of a rebase, then it might affect IDs 
and so be physically distinct even if it's not logically different.

I'd like to be able to see whether a patch set has introduced any changes at all to the code, such as 
by displaying a * next to diffs that are different in this patch set.
Jan 7, 2010
Project Member #1 bklarson@gmail.com
Have you tried the 'Patch History' drop down box at the top-left of a file comparison 
page? I usually compare a file with the previous version, then just hit the 'next 
file' button repeatedly to skim through all files and check if anything changed.
Jan 7, 2010
#2 alex.ble...@gmail.com
Yes, that's what I do. but it's frustrating when there's 20 files, and only one of them has changed - or worse, 
nothing has changed but because it's a dependent change to something else, it's been automatically 
resubmitted.
Jan 11, 2010
#3 sop@google.com
This is apparently also related to  issue 160  and  issue 194 .
Status: Accepted
Blockedon: 160 194
Jan 11, 2010
#4 sop@google.com
(No comment was entered for this change.)
Labels: -Type-Bug Type-Feature
Jun 15, 2010
#5 sop@google.com
 Issue 160  has been merged into this issue.
Cc: scroggo+...@google.com
Jun 15, 2010
#6 sop@google.com
(No comment was entered for this change.)
Blockedon: -160
May 20, 2011
#7 sop@google.com
This still isn't implemented, however 2.1.7 will allow you to compare two patch sets and see only the files that actually differ between them. Assuming they share the same parent (was not rebased) this view will display only the file names that were modified.

Unfortunately that may hide a file you commented on, but that was not changed in the newer patch set.
Aug 5, 2012
#8 alon.barlev@gmail.com
Just wanted to comment that this is one of the most annoying behaviours of gerrit, although it is perfect for review, every rebase adds noise via mails and new patchset within history although nothing really changed.

Rebase may occurs even if some previous patch had been changed, or simple rebase on master. When this happens all depended patches are updated with a new path sets which are identical to the previous ones with only parent changed.

There is no value in reviewing identical patches...
Dec 20, 2012
Project Member #9 bruce.zu@sonymobile.com
https://gerrit-review.googlesource.com/#/c/33091/ will help a bit
I will redo it in a new change.
Blockedon: -gerrit:194 gerrit:194
Jan 14, 2014
#10 mani.cha...@tcs.com
Do we already have a change submitted for this issue?
Feb 19, 2014
Project Member #11 david.pu...@sonymobile.com
On the new change screen, files that have been reviewed are marked with a checkbox in the file list.

Files that are unchanged in subsequent patch sets remain checked.  Files that have been changed are unchecked.