Issue 3624: Commit message inline editing doesn't conform to Git behavior
Status:  WontFix
Owner: ----
Closed:  Oct 21
Cc:
Reported by org...@gmail.com, Oct 20, 2015
Affected Version: 2.11

What steps will reproduce the problem?
1. Edit a commit message
2. Add some blank lines

For example:

--- snip ---
Commit Subject





One long paragraph
that spans over
multiple lines





And another paragraph
that has only two lines.
--- snap ---

What is the expected output? What do you see instead?
When this commit message is passed to git commit (either in the commit editor, or by an external file with -F), subsequent blank lines are squashed, leaving a single blank line after each paragraph.

This is the default behavior. It can be changed by passing --cleanup=verbatim, which preserves the message as it is.

Gerrit doesn't clean up blank lines like the default mode in Git.
Oct 21, 2015
Project Member #1 david.pu...@sonymobile.com
I have no opinion on what the correct behaviour should be, but it should be noted that the current behaviour is the same as what happens when committing something on Github with their UI:

https://github.com/dpursehouse/sandbox/commit/612d965daa87906f8beae11ad5b0e6fcd4a5a0ea

In that commit the only cleanup was the trailing blank lines that I added after the footers.  Gerrit doesn't do that, but it will when the fix for  issue 3616  is merged.

I would say that this is nice to have, but it's not something that I think needs to be fixed for 2.11.x.  I would punt it to 2.12 or later.  I would even suggest changing the categorisation from bug to feature request.


Cc: David.Os...@gmail.com
Oct 21, 2015
Project Member #2 David.Os...@gmail.com
I agree with what David said, clearly a WONTFIX to me.
Status: WontFix