Issue 3447: VHDL syntax highlighting
Status:  Released
Owner: ----
Closed:  Nov 6
Reported by roman.ka...@gmail.com, Jun 23, 2015
At the moment (gerrit 2.11.1), VHDL syntax highlighting is not supported by the change screen. Is there any chance that this will by integrated into gerrit at some point?

If not, is there a way how we could extend gerrit to support VHDL syntax highlighting, e.g. by a plugin?
Jun 23, 2015
Project Member #1 David.Os...@gmail.com
Gerrit is using CodeMirror for SideBySide view. It seems that VHDL language is not supported
by CodeMirror atm: [1]. However, in this post to their dev ML adjustment to Verilog mode was
published, that should work for VHDL as well: [2]. So you could try to build custom Codemirror
version and include this patch and verify if it works.

AFAICT, the maintainers of CodeMirror project also accept sponsoring for implementing new
language modes. You may want to contact them and ask. Once CodeMirror supports VHDL
it would be very easy to extend Gerrit to support it as well.

You cannot add new language mode in Gerrit plugin, atm.

* [1] https://codemirror.net/mode/index.html
* [2] https://groups.google.com/d/topic/codemirror/uRUuqXimqj0/discussion
Status: AwaitingInformation
Jun 24, 2015
Project Member #2 David.Os...@gmail.com
As workaround for now you could use Unified diff view instead of SideBySide diff view.
Jul 10, 2015
#3 m...@google.com
I rewrote the VHDL mode and created a pull request to upstream CodeMirror:
https://github.com/codemirror/CodeMirror/pull/3372

Hopefully it will be merged, and when Gerrit updates CodeMirror, we will support VHDL syntax highlighting.
Jul 10, 2015
#4 roman.ka...@gmail.com
Glad to hear!
Oct 15, 2015
Project Member #5 David.Os...@gmail.com
https://gerrit-review.googlesource.com/71553
Status: ChangeUnderReview
Nov 6, 2015
Project Member #6 huga...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.12
Dec 21, 2015
Project Member #7 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released