Issue 3400: Reviewers plugin UI is broken due to mis-generated links in Gerrit 2.11
Status:  Submitted
Owner: ----
Closed:  Jun 2015
Cc:
Project Member Reported by bassem.rabil, May 29, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version:
Gerrit 2.11 with reviewers plugin from stable-2.11 branch

What steps will reproduce the problem?
1. Create a project with "/" in name, e.g. "aa/bb"
2. Try clicking on Reviewers tab in project screen
In the reverse proxy config "AllowEncodedSlashes On" is already configured.

What is the expected output? What do you see instead?
The reviewers plugin UI should be opened, but instead you get:

"Code Review - Error
The page you requested was not found, or you do not have permission to view this page."


Please provide any additional information below.

The generated link for Reviewers plugin web UI is:
https://<Gerrit Instance URL>/#/x/reviewers/aa%2Fbb
 instead of 
https://<Gerrit Instance URL>/#/x/reviewers/aa/Fbb 

This used to work correctly in Gerrit 2.10. It looks like this is a regression in Gerrit 2.11 in the way plugins contribute links in project context with project names including "/".


May 31, 2015
Project Member #1 David.Os...@gmail.com
(No comment was entered for this change.)
Cc: edwin.ke...@sap.com
Jun 1, 2015
Project Member #2 David.Os...@gmail.com
@Edwin, this regression was caused by this commit: [1]. Can you have a look?

* [1] https://github.com/gerrit-review/gerrit/commit/f2d4c991f675805acf6011481df6707171e907c3
Status: AwaitingInformation
Jun 2, 2015
Project Member #3 edwin.ke...@gmail.com
It is correct that the project name is encoded in the URL
  https://<Gerrit Instance URL>/#/x/reviewers/aa%2Fbb

The Reviewers plugin should decode it.
Jun 2, 2015
Project Member #4 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/68280
Status: ChangeUnderReview
Jun 2, 2015
Project Member #5 edwin.ke...@gmail.com
The fix was moved to stable-2.11:
  https://gerrit-review.googlesource.com/68281
Jun 2, 2015
Project Member #6 huga...@gmail.com
fixed in stable-2.11 branch
Status: Submitted