Issue 3389: Users => Settings => Contact Information is broken
Status:  Released
Owner: ----
Closed:  Jun 2015
Cc:
Project Member Reported by David.Os...@gmail.com, May 25, 2015
Affected Version:

2.11-644-g033c2a4

What steps will reproduce the problem?
1. Loggin to gerrit-review
2. Click on Users => Settings => Contact Information

What is the expected output?

contact information can be edited

What do you see instead?

Empty page and JavaScript error:

Mon May 25 22:06:43 GMT+200 2015 com.google.gwt.logging.client.LogConfiguration
SEVERE: undefined
java.lang.ClassCastException
	at Unknown.$fillInStackTrace(gerrit_ui-0.js)
	at Unknown.RuntimeException(gerrit_ui-0.js)
	at Unknown.ClassCastException(gerrit_ui-0.js)
	at Unknown.checkType(gerrit_ui-0.js)
	at Unknown.dynamicCastJso(gerrit_ui-0.js)
	at Unknown.$editableAccountFields(gerrit_ui-3.js)
	at Unknown.$canEdit(gerrit_ui-3.js)
	at Unknown.$onInitUI_1(gerrit_ui-3.js)
	at Unknown.onInitUI_2(gerrit_ui-3.js)
	at Unknown.onLoad_5(gerrit_ui-3.js)
	at Unknown.onAttach_0(gerrit_ui-0.js)
	at Unknown.$setParent(gerrit_ui-0.js)
	at Unknown.$add_2(gerrit_ui-0.js)
	at Unknown.$add_3(gerrit_ui-0.js)
	at Unknown.$add_5(gerrit_ui-6.js)
	at Unknown.onInitUI_6(gerrit_ui-3.js)
	at Unknown.onLoad_1(gerrit_ui-0.js)
	at Unknown.onAttach_0(gerrit_ui-0.js)
	at Unknown.$setParent(gerrit_ui-0.js)
	at Unknown.$setWidget(gerrit_ui-0.js)
	at Unknown.setWidget(gerrit_ui-0.js)
	at Unknown.$add(gerrit_ui-0.js)
	at Unknown.$setView(gerrit_ui-0.js)
	at Unknown.display_1(gerrit_ui-0.js)
	at Unknown.onSuccess_2(gerrit_ui-3.js)
	at Unknown.execute_26(gerrit_ui-0.js)
	at Unknown.runScheduledTasks(gerrit_ui-0.js)
	at Unknown.$flushPostEventPumpCommands(gerrit_ui-0.js)
	at Unknown.execute_28(gerrit_ui-0.js)
	at Unknown.execute_27(gerrit_ui-0.js)
	at Unknown.apply_4(gerrit_ui-0.js)
	at Unknown.entry0(gerrit_ui-0.js)
	at Unknown.anonymous(gerrit_ui-0.js)
	at Unknown.callback(gerrit_ui-0.js)

Please provide any additional information below.

dbg=1 was used to obtain de-obfuscated stack trace:

https://gerrit-review.googlesource.com/?dbg=1#/settings/contact
May 25, 2015
Project Member #1 edwin.ke...@gmail.com
I'm unable to reproduce this on a local system. It might be an issue specific to the gerrit-review server. Can anyone from Google have a look?
Labels: Environment-Google
May 26, 2015
Project Member #2 David.Os...@gmail.com
(No comment was entered for this change.)
Status: AwaitingInformation
Cc: -edwin.ke...@sap.com jrn@google.com
Jun 2, 2015
Project Member #3 David.Os...@gmail.com
Anyone? It's broken for weeks now.
Jun 3, 2015
Project Member #4 jrn@google.com
I think the breakage is at gerrit-gwtui/src/main/java/com/google/gerrit/client/config/GerritInfo.java:

private final native JsArray<AccountFieldNameInfo> _editableAccountFields()
/*-{ return this.editable_account_fields; }-*/;

Should that be a JsArrayString instead?
Jun 3, 2015
Project Member #5 jrn@google.com
I can reproduce this by applying the following patch to gerrit:

diff --git i/tools/gwt-constants.defs w/tools/gwt-constants.defs
index a406aa8..b84d422 100644
--- i/tools/gwt-constants.defs
+++ w/tools/gwt-constants.defs
@@ -2,7 +2,6 @@ GWT_JVM_ARGS = ['-Xmx512m']
 
 GWT_COMPILER_ARGS = [
   '-XdisableClassMetadata',
-  '-XdisableCastChecking',
 ]
 
 GWT_COMMON_DEPS = [
Jun 3, 2015
Project Member #6 jrn@google.com
https://gerrit-review.googlesource.com/68370
Status: ChangeUnderReview
Jun 3, 2015
Project Member #7 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: -Environment-Google FixedIn-2.12
Jun 3, 2015
Project Member #8 David.Os...@gmail.com
GWT_COMPILER_ARGS = [
   '-XdisableClassMetadata',
-  '-XdisableCastChecking',
 ]

Should this trick be mentioned in Documentation/dev-eclipse.txt?

"This document is about configuring Gerrit Code Review into an
Eclipse workspace for development and debugging with GWT."

Dec 21, 2015
Project Member #9 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released