Issue 3320: Gerrit wrongfully ignores UI request to add missing group member(s) to review
Status:  Invalid
Owner: ----
Closed:  Apr 2015
Project Member Reported by marco.mm...@gmail.com, Apr 20, 2015
Affected Version: 0f311ec; also seen in 2.10.2-31-g361cb34 and other unidentified (earlier) version.

What steps will reproduce the problem?
scenario; cf. dannorth.net/whats-in-a-story:

Given a gerrit group named 'us'
  And Alice part of that group
  And Bob also part of that group
  And a change C being reviewed
  And Alice already a +1-er for that change
  And Bob not added yet as reviewer for that change (C)
  And another user account with its email address starting with 'us'
When adding group 'us' as reviewer for change C in UI
Then gerrit wrongfully matches group 'us' and account with email starting with 'us'
  And gerrit invalidates that user wrongfully deemed as C reviewer candidate
  And gerrit (then) does not add group 'us' (i.e., missing Bob) as C reviewer.

What is the expected output? What do you see instead?
-Expected: Bob added as reviewer alongside Alice, in UI.
-Actual: no such addition; gerrit looks like ignoring the request in its UI.

Please provide any additional information below.
In the PostReviewers class, this code block starting at line 198 should maybe go away:
(..)
    for (AccountExternalId extId : schema.get().accountExternalIds()
        .suggestByEmailAddress(a, b, 10)) {
      result.add(extId.getAccountId());
    }
(..)
More tests and reviews would of course be needed prior to removing or changing code!

Addendum: if group name "matches" more than one account email prefix, the group (its missing members) *will* be added as reviewers.
/Marco M.
Apr 20, 2015
Project Member #1 marco.mm...@gmail.com
Typo above: should read AccountResolver rather than PostReviewers
Apr 21, 2015
Project Member #2 huga...@gmail.com
(No comment was entered for this change.)
Status: Invalid