Issue 3296: Removing approvals from a change in submitted state does not remove change from merge queue
Status:  WontFix
Owner: ----
Closed:  Dec 17
Project Member Reported by david.pu...@sonymobile.com, Apr 14, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: master

What steps will reproduce the problem?
1. Upload change1
2. Upload change2 based on change1
3. Add review labels on change2 to make it submittable, for example Code-Review+1 and Verified+1
4. Submit change2
5. After seeing "Could not merge" message, change Code-Review+2 to Code-Review-1
6. Approve and submit change1

What is the expected output? What do you see instead?

Actual: When change1 is submitted and merged, change2 is also merged despite now not having the necessary Code-Review label.

Expected: when changing Code-Review +2 score to -1 on change2, change2 should be removed from the merge queue and should not be merged at the same time as change1.

Please provide any additional information below.

Found this bug on 2.8.6.x and reproduced on stable-2.11-rc2

Dec 17, 2015
Project Member #1 david.pu...@sonymobile.com
No point trying to fix this; the merge queue is gone from 2.12 onwards.
Status: WontFix