Issue 3194: Modal "sign in" dialog appears behind CodeMirror
Status:  Duplicate
Merged:  issue 2361
Owner: ----
Closed:  Apr 2015
Project Member Reported by dougk....@gmail.com, Feb 19, 2015
Affected Version: 2.9.1, 2.10

What steps will reproduce the problem?
1. View a code review on ChangeScreen2, with a side-by-side diff visible.
2. ssh <server> -p 29418 gerrit flush-caches --cache web_sessions
3. Click the "My->Changes" link in the browser.

What is the expected output? What do you see instead?
The Sign-In modal dialog appears on the screen, but it appears under the CodeMirror screen.  Similarly, the "Page Not Found" modal is shown if you try to navigate through the change with the [, ] keys (three of them are stacked on the page, and a fourth "page not found" is loaded under those), instead of asking the user to sign in again.

Note: this happens specifically when using the HTTP_LDAP auth method. The LDAP auth works slightly differently because it actually prompts through the UI and doesn't rely on HTTP Basic credentials.  I tested against gbe09512 as well, and found the Changes link now gives a "not signed in" modal over the entire screen (but doesn't prompt to sign in), and attempting to go to the next page gives a "session expired" modal across the entire page, which does allow sign-in.  Of course, this all goes away if you refresh the screen as well.  So, in the later versions on master, maybe a better assessment of the problem is not the broken modal on CodeMirror, but that there is now inconsistent behavior of not signed in vs. session expired errors.
Feb 19, 2015
Project Member #1 edwin.ke...@gmail.com
Is this fixed by
  https://gerrit-review.googlesource.com/62833
Feb 19, 2015
Project Member #2 dougk....@gmail.com
Here's a screenshot of the behavior in 2.9.1.  Sorry I had to crop out a lot of the screen, but hopefully you still get the idea.
broken-session-expired-modal-cropped.png
18.8 KB   View   Download
Feb 19, 2015
Project Member #3 dougk....@gmail.com
Ah yep, so it looks like it would be the same issue.  Any thoughts on why master shows slightly different behavior with different links/actions producing session expired vs. not signed in errors? Actually, even worse, if I change my development system to remove anonymous access, I consistently get "not signed in" or "page not found" depending on the route I take -- no session expired anymore.

I guess it's somewhat two bugs in one report, so we can continue this discussion elsewhere, if needed.
Feb 19, 2015
Project Member #4 u.wol...@gmail.com
Isn't this a duplicate of  issue #2361 ?
Feb 19, 2015
Project Member #5 dougk....@gmail.com
Yeah, the screenshot definitely is (and it appears to be fixed as Edwin pointed out), but the "page not found" and inconsistent "not signed in" behavior isn't documented anywhere that I'm aware.
Apr 28, 2015
Project Member #6 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 2361