Issue 2982: Code Review +2 button vanishes after rebase
Status:  Invalid
Owner: ----
Closed:  Oct 2014
Reported by lars.vo...@vogella.com, Oct 21, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. I have a Code Review +2 button (see screenshot)
2. After I press "Rebase" this button goes away


What is the expected output? What do you see instead?

That the button stays visible

Please provide any additional information below.

button.png
63.7 KB   View   Download
Oct 21, 2014
Project Member #1 edwin.ke...@gmail.com
This is expected. The so called "quick approve" buttons like "Code-Review+2" and "Verified+1" appear only if the corresponding label is the only label that is still missing an approval for making the change submittable. This means if Gerrit is configured to require approvals in Code-Review and Verified for submitting a change, "Code-Review+2" only appears if the change has already a +1 Verified approval. By rebasing the change, the Verified approval is removed and hence "Code-Review+2" doesn't show up anymore. This is also explained in the documentation:

  https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#reply
Oct 21, 2014
#2 lars.vo...@vogella.com
Thanks, makes sense. Please close this bug as invalid.
Oct 21, 2014
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Invalid