Issue 2960: Window Titles Not Displaying Filenames
Status:  Released
Owner: ----
Closed:  Nov 2014
Reported by Crazy...@gmail.com, Oct 14, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Open any review and compare the changes of any file.

What is the expected output? What do you see instead?

I would like the window title to display the path and name of the file being displayed.

Contrary to the fixes committed for  issue 129 , the window title merely displays the server name and the text "Code Review".

Please provide any additional information below.

Oct 14, 2014
#1 Crazy...@gmail.com
Sorry, I forgot the Gerrit version.  We're using 2.9.
Oct 25, 2014
#2 richard.moehn@googlemail.com
Confirmed in 2.10-rc0-769-g5f9a9e4 and also easily observable in the Gerrit instance for the Gerrit project itself.

Here's my version of the phenomenon:

 * When I open a change/review and open the changes for a file in the same tab, the window title is:

     "Change <change id>: <commit message> | <server name> Code Review"

 * When I open a change/review and open the changes for a file in a new tab, the window title is:

     "<server name> Code Review"

Is it the same on your side or are you always getting the second kind of title?

A note about me: I'm new on the Gerrit project and looked into this bug, because I thought it might be a good thing to start with. I will continue looking into it, but it might take a while. (Don't even have the Contributer Agreement thing settled, yet.) If someone wants to resolve the issue quickly, feel free to do so. I'll look around for something else to do.
Oct 25, 2014
#3 Crazy...@gmail.com
Hi Richard,

I've been out of the office all last week, so I'm going from memory, but I think I'm seeing the same behaviour you are.

I can confirm this on Monday though.

Cheers,
James

Oct 26, 2014
#4 richard.moehn@googlemail.com
Progress update: I found the reason for the regression. It's the "New Change Screen". It also introduced a new side-by-side diff screen and the class responsible for that doesn't set the window title, whereas the old side-by-side diff class did.

You should be able to confirm, that by switching back to the Old Change Screen you get your filenames back. However, for some reason neither the Gerrit Gerrit nor my test Gerrit want to show me the Old Change Screen when I choose it in the preferences. Not sure why. If you have the same issue, you can switch to unified diff mode. This still has an old implementation and should show you the filename in the window title.

I'll propose a solution as soon as my Contributor Agreement is through.
Nov 12, 2014
Project Member #5 huga...@gmail.com
https://gerrit-review.googlesource.com/#/c/61497
Status: ChangeUnderReview
Nov 17, 2014
Project Member #7 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9.2
Nov 30, 2014
Project Member #8 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released