Issue 2865: its-jira commentOnXXX configuration does not work
Status:  Submitted
Owner: ----
Closed:  Sep 2014
Reported by mvtor...@gmail.com, Aug 26, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: its-jira latest 2.9 build

What steps will reproduce the problem?
1. Enable its-jira plugin
2. Add the following to gerrit.config
[its-jira]        
        url = jiraurl
        username = username        
        commentOnChangeAbandoned = true
        commentOnChangeCreated = false
        commentOnChangeMerged = true
        commentOnChangeRestored = true
        commentOnCommentAdded = false
        commentOnFirstLinkedPatchSetCreated = false
        commentOnPatchSetCreated = false
        commentOnRefUpdatedGitWeb = false


What is the expected output? 
No comments added on specified commentOnXXX=false

What do you see instead?
Comments are being added

Please provide any additional information below.
This works with 

[its-jira]        
        url = jiraurl
        username = username        
[jira]
        commentOnChangeAbandoned = true
        commentOnChangeCreated = false
        commentOnChangeMerged = true
        commentOnChangeRestored = true
        commentOnCommentAdded = false
        commentOnFirstLinkedPatchSetCreated = false
        commentOnPatchSetCreated = false
        commentOnRefUpdatedGitWeb = false


There's a bug in GerritHookFilterAddComment where it uses ItsFacade.name() to get the config, but JiraItsFacade returns "Jira"
 
Sep 2, 2014
Project Member #1 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/59714
Status: ChangeUnderReview
Sep 16, 2014
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted