Issue 276: URL linkification still pulling in trailing non-URL chars
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Daniel Sandler <dsandler@google.com> on Wed Sep 02 11:25:09 PDT 2009
Source: JIRA GERRIT-277

Change <https://review.source.android.com/Gerrit#change,9378> has a
description including the text:

"""
armv4 was only implemented on StrongArm and Arm8 (See http://en.wikipedia.org/wiki/ARM_architecture)
and will be more difficult to support since it does not support the bx
instruction.
"""

The auto-linked URL becomes "http://en.wikipedia.org/wiki/ARM_architecture)",
which incorrectly includes the right paren.  I'm pretty sure that most auto-
linkifiers would exclude the right paren in this case, but I don't know how
complicated it makes the regex (or whatever).
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Daniel Sandler <dsandler@google.com> on Wed Sep 02 11:26:54 PDT 2009

[Er, oops, guess I shouldn't have used Clone.]

Anyway: this is still happening, not with right-parens but with right-angle-
brackets.

Ironically, you can see this in action on:
https://review.source.android.com/#change,9380

Trailing periods, commas, etc. are also gobbled up by the URL. (Yes, these are
legal URL chars but almost never in a trailing context.)
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Sep 03 10:35:28 PDT 2009

Fixed by Ide9a63c3c998eac6a3ce9f23066668c2e7a9aba6 and
I49ca8951cd88c9dd3505dda2761ef8c9e700aab0
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Sep 03 10:35:28 PDT 2009

Fixed in version 2.0.21.
Status: Fixed
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.21
Oct 21, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released