Issue 2691: Parameter --reviewer for hooks ref-updated empty on merges
Status:  New
Owner: ----
Reported by jcd.de...@gmail.com, May 31, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8

What steps will reproduce the problem?
1. Set up a project "Submit Type" to "Merge if Necessary"
2. Have a CL submitted via the UI trigger an automatic merge by Gerrit
3. Notice in the ref-updated hook that the argument for --reviewer is empty

What is the expected output? What do you see instead?

Not sure about the expected output here since it might be a design choice from the developers. However, I couldn't find mention of such case in the hooks documentation. My expectation was that the --reviewer was always provided.

Please provide any additional information below.

We are using the ref-updated hook to trigger email notifications for each change, and have the From: of those notifications set to the reviewer (as provided by Gerrit through the --reviewer command line option of the ref-updated hook). We noticed that in case of automatic merge from Gerrit, the reviewer is not provided for both the "original" commit and the "merge" commit:

commit 49fc1e640c2fb6f968f2f1740c9b6b68a9cd13af
Author: Developer A <a@corporate.com>
Date:   Thu May 22 17:01:48 2014 +0200

    Do stuff.
    
    Change-Id: I8f3e6abb7d0086adf51f792dfa463616d5832529

commit a890bcd67c367cedb93425520e766ffc9ebea25e
Merge: 55c707f 49fc1e6
Author: Reviewer B <b@corporate.com>
Date:   Fri May 23 15:15:46 2014 +0200

    Merge "Do stuff" into <repo>

Our ref-updated hook is similar to https://gist.github.com/4340197.
Please ask if we can provide any additional data.