Issue 261: Sometimes comments don't appear in the side by side view
Status:  Released
Owner:
Closed:  Oct 2012
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Wink Saville <wink@saville.com> on Wed Aug 19 18:07:24 PDT 2009
Source: JIRA GERRIT-262
Affected Version: 2.0.18
Environment: Seen on partner repo

Sometimes a comment is not seen. I'm guessing its because the comment
isn't associated with a unchanged line, but since I can't see them
I'm not sure.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Aug 19 18:23:54 PDT 2009

Looking at the case wink pointed out to me privately, it looks like what
happened was the file changed mode from 644 to 755, but *nothing* else was
modified on it.  So the blob ids were identical.  Since the blob ids were
identical we probably skipped out early on the edit list generation and didn't
collect the comments together, resulting in nothing to render.

Either that, or maybe commit c059790c717d5ca80f4289a5dafbab88a60269ca[1] has
something to do with this.  Need to look at it more.

[1] http://android.git.kernel.org/?p=tools/gerrit.git;a=commit;h=c059790c717d5ca80f4289a5dafbab88a60269ca
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Aug 31 11:11:30 PDT 2009

Another case Wink pointed out to me has the line_nbr property of the comment
set to 0.  Since 0 is not a valid line number in the file, on either side, we
would never try to display the context or the comment, as we would never
encounter line 0 during our passes through the file.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Aug 31 14:00:32 PDT 2009

Fixed by I3e09bada23be68f417a949b5b6969c8c75523ca5 as well as applying an
upgrade script to the database:

 UPDATE patch_comments SET line_nbr = 1 WHERE line_nbr < 1;
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Aug 31 14:00:32 PDT 2009

Fixed in version 2.0.20.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.20
Oct 21, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released