Issue 2583: Gerrit does not reject draft comments posted on non-existing files
Status:  Released
Owner: ----
Closed:  Jul 2014
Reported by l13uw3hu...@gmail.com, Apr 3, 2014
Affected Version:
Gerrit v2.8.3

What steps will reproduce the problem?
We use Jenkins with the Gerrit plugin to trigger some code inspections on CSS and PHP files. I wrote some scripting to post review remarks automatically using the REST API. After the build, Jenkins reviews the change with a score using SSH. 

What is the expected output? What do you see instead?
I expect to see all the remarks available to every user, but instead only the comment "Patch Set 4: (169 comments) Build Successful" is appearing.

Please provide any additional information below.
I find it very curious that the email send after review does contain all remarks. Further, this functionality has worked in Gerrit v2.7. The log files do not show any related information to me.

Enabled plugins: commit-message-length-validator, deleteproject, download-commands, gravatar, replication, reviewnotes
Apr 3, 2014
Project Member #1 david.pu...@sonymobile.com
Are the review comments not visible in the UI after opening the individual files?

Note that the cover message that you see on the main change screen will only show the "(169 comments)" by design.

Status: AwaitingInformation
Apr 4, 2014
#2 l13uw3hu...@gmail.com
No, the review comments them selves were not visible at all in Gerrit. After further analyzing this issue, I run into a bug in my script which crops a character from the filename. I did not think of this earlier because Gerrit did accept the review notes, and did email them nicely. Which is odd, because the file on where Jenkins posted the comments on does not exists.

So I think my bug report should be: Gerrit does not reject draft comments posted on inexisting files.
Apr 8, 2014
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Summary: Gerrit does not reject draft comments posted on non-existing files (was: Comments via REST API not visible after Review)
Apr 8, 2014
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: New
Apr 10, 2014
Project Member #5 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/55890
Status: ChangeUnderReview
Apr 28, 2014
#6 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Apr 28, 2014
Project Member #7 edwin.ke...@gmail.com
The fix was reverted because it broke some tests:
  https://gerrit-review.googlesource.com/56540
Status: New
Labels: -FixedIn-2.9
Apr 29, 2014
Project Member #8 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/56590
Status: ChangeUnderReview
Jul 14, 2014
Project Member #9 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.10
Jan 27, 2015
Project Member #10 ziv...@gmail.com
(No comment was entered for this change.)
Status: Released