Issue 243: comment [save] button not always enabled
Status:  Released
Owner:
Closed:  Oct 2012
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Wed Jul 15 22:22:15 PDT 2009
Source: JIRA GERRIT-244

1.  Go into a code review and into a side-by-side view
2.  Double-click on an LOC and enter a comment.  Hit [save].
3.  Click [Edit] to re-enter the comment.  Notice that [save] is greyed
because you made no changes yet.
4.  Double-click a word in the comment you already entered, and type
<backspace>.

Bug:  [Edit] is still greyed out even though you made changes.

Workaround:  Type any char and backspace it.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Cedric Beust <cbeust@google.com> on Thu Jul 16 11:08:39 PDT 2009

I just verified with Andy:  this only happens on Safari, not on Firefox.

Now to determine whether it's a Safari or GWT bug...  Shawn, any thoughts?
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Jul 16 11:11:47 PDT 2009

I also see this in Chrome.  I think its a WebKit bug.

Even if its not though, we use our own handler for this code, see
TextSaveButtonListener for the code that handles the events.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat Jul 18 11:35:36 PDT 2009

Fixed by https://review.source.android.com/10709 by just always leaving the
Save button enabled.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat Jul 18 11:35:36 PDT 2009

Fixed in version 2.0.17.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.17
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released