Issue 241: Gerrit should handle the "no changes" state better
Status:  Released
Owner:
Closed:  Oct 2012
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Ed Heyl <edheyl@google.com> on Tue Jul 14 09:09:31 PDT 2009
Source: JIRA GERRIT-242
Affected Version: 2.0.16

Right now if I pick a set of patch sets to compare and a given file does not
have any changes, Gerrit displays that the file does not have any changes.
However, if I click on the link for the next file in the set, if that file
does not have any changes Gerrit displays a message "Unexpected Error: No
Differences".

Expected: It should just navigate to the file and display that there are no
changes.  Otherwise I am forced to go up to the change or undo the patch set
settings and continue, and then reset the patch set I am comparing.

Original bug: http://b/issue?id=1978961
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Update by Ed Heyl <edheyl@google.com> on Tue Jul 14 09:11:22 PDT 2009

Change description to:
----
Right now if I pick a set of patch sets to compare and a given file does not
have any changes, Gerrit displays that the file does not have any changes.
However, if I click on the link for the next file in the set, if that file
does not have any changes Gerrit displays a message "Unexpected Error: No
Differences".

Expected: It should just navigate to the file and display that there are no
changes.  Otherwise I am forced to go up to the change or undo the patch set
settings and continue, and then reset the patch set I am comparing.

Original bug: http://b/issue?id=1978961
----
Labels: -Type-Bug Type-Feature
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Cedric Beust <cbeust@google.com> on Tue Jul 14 09:11:59 PDT 2009

Yes, I have a fix pending review for this:

https://review.source.android.com/#change,10644

Should get it in soon.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jul 15 06:51:26 PDT 2009

Fixed by https://review.source.android.com/10644
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jul 15 06:51:26 PDT 2009

Fixed in version 2.0.17.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.17
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released