Issue 2395: Max width of 1484px is inapproppriate for larger screen resolutions
Status:  Released
Owner: ----
Closed:  Jan 2014
Reported by jivko.va...@egym.de, Jan 13, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.1.8

What steps will reproduce the problem?
1. Use a large monitor (with horizontal resolution greater than 1484 pixels).
2. Open a file for review in the comparison view (using the new view, the ission appears not to be present with the old diff-table view).
3. Observe as there is an empty space on the right, as the width is limited to '1484px'.

What is the expected output? What do you see instead?

Expected would be to fill the whole window with the view and not only a part of it which makes the code also harder to review.

Please provide any additional information below.

Please remove the 'max-width: 1484px;' from the Difftable.ui.xml or make it configurable. Currently the problem seems to be caused by this line: '.difftable { max-width: 1484px; }' As I see this same maximal width is also present in the Header.ui.xml so it might also be occurring in other parts of the code as well.


gerrit-issue.png
11.7 KB   View   Download
Jan 13, 2014
#1 jivko.va...@egym.de
The affected version is actually 2.8 and not 2.1.8, sorry for the confusion.
Jan 13, 2014
#2 wuerting...@gmail.com
I attached a patch which might solve the problem. However, I'm wondering why the max-width is set in the first place? Maybe there's a good reason for that.

It would be great if we could change the width to be configurable. Maybe I'll find the time to write a patch for that.
2395.patch
558 bytes   Download
Jan 13, 2014
#3 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Jan 14, 2014
#5 wuerting...@gmail.com
Wow, that was quick. Thanks!
Jan 14, 2014
#6 jivko.va...@egym.de
I also would like to thank you for the quick response!
Jul 18, 2014
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released